jdk
jdk copied to clipboard
8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
Simple change of removing an if
check.
Test: hotspot_gc
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
Reviewers
- Thomas Schatzl (@tschatzl - Reviewer)
- Kim Barrett (@kimbarrett - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10712/head:pull/10712
$ git checkout pull/10712
Update a local copy of the PR:
$ git checkout pull/10712
$ git pull https://git.openjdk.org/jdk pull/10712/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10712
View PR using the GUI difftool:
$ git pr show -t 10712
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10712.diff
:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@albertnetymk The following label will be automatically applied to this pull request:
-
hotspot-gc
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@albertnetymk This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
Reviewed-by: tschatzl, kbarrett
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 14 new commits pushed to the master
branch:
- 8487c56f7ea224169d9d42efda9efb824266289f: 8295294: Misc cleanups in runtime/InvocationTests
- 0043d58c5d52c3b299a4b6dfcec34a7db5041aea: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
- 2e2a51ee22068e847b36f9a5f20bd37050eaabf8: 8295267: Improve G1 scan to merge ratio calculation
- dfcd9d538eba4b097083abe19d02d6d019236ac7: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
- 2da079c64e880835c9c0eb36f5e63a7752ebb328: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks
- 449b52fd230786e818cdaf5000213ea746802e4d: 8295158: G1: Increase card-based cost sample reporting threshold
- 312985eea6237d75fae0f3c0cceb4f16e18b73b4: 8295156: G1: Improve constant other time calculation
- 786ce1c27b1da6096ad820170263d6b354e0d41a: 8295024: Cyclic constructor error is non-deterministic and inconsistent
- 1efa93e602455d7a032eb97cffa56da7337dd8f9: 8294844: Improve G1 young gen length revise trigger
- 3dbc38a2c903f533ace847a3bc0d2687f263fafd: 8295288: Some vm_flags tests associate with a wrong BugID
- ... and 4 more: https://git.openjdk.org/jdk/compare/7133fc93e168f3671d048b2ae654f84ec289b98d...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master
branch, type /integrate in a new comment.
Thanks for the review.
/integrate
Going to push as commit 172006c0e9433046252bd79e8864890ab7c0ce56.
Since your change was applied there have been 24 commits pushed to the master
branch:
- 7743345f6f73398f280fd18364b4cea10a6b0f2f: 8294314: Minimize disabled warnings in hotspot
- 552d8a2821f03046896a728d6e4cec0ef754d3f4: 8295192: Use original configure command line when called from a script
- cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
- b3bb3e6ed89f3abcaae584fcbe75688141e886cb: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
- 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0: 8295110: RISC-V: Mark out relocations as incompressible
- 74a51ccc86525eb4b1eb2e5cb11e605ca9e9fc5d: 8292698: Improve performance of DataInputStream
- d3781ac8a38943d8a20304e770b01d5418ee33d0: 8295009: RISC-V: Interpreter intrinsify Thread.currentThread()
- e7d0ab227ff86bb65abf7fbeb135ce657454200b: 8295379: ProblemList java/lang/Float/Binary16Conversion.java in Xcomp mode on x64
- 404e8de1559adade31df98a83919841f080b5b89: 8294865: x86: Improve the code generation of MulVB and MulVL
- 2087424736f15a5a80a0492993a6cd74da87188a: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString
- ... and 14 more: https://git.openjdk.org/jdk/compare/7133fc93e168f3671d048b2ae654f84ec289b98d...master
Your commit was automatically rebased without conflicts.
@albertnetymk Pushed as commit 172006c0e9433046252bd79e8864890ab7c0ce56.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.