8295262: Build binutils out of source tree

[luhenry]

trafficstars

Currently, when passing --with-binutils-src, binutils is built in the source tree. That leads to conflicting targets when compiling for different architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) from the same jdk source tree.

The simplest solution is to build binutils out-of-tree and into the build//binutils folder. These out-of-tree builds are already supported by binutils and only require some changes in the way we invoke the binutils/configure command.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8295262: Build binutils out of source tree

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10689/head:pull/10689
$ git checkout pull/10689

Update a local copy of the PR:
$ git checkout pull/10689
$ git pull https://git.openjdk.org/jdk pull/10689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10689

View PR using the GUI difftool:
$ git pr show -t 10689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10689.diff

[bridgekeeper[bot]]

:wave: Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@luhenry The following labels will be automatically applied to this pull request:

• build
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (c78d2f02)
• 01: Full - Incremental (8faf5083)
• 00: Full (b69fdbaa)

[openjdk[bot]]

@luhenry This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295262: Build binutils out of source tree

Reviewed-by: shade, erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• 0919a3a0c198a5234b5ed9a3bb999564d2382a56: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b83bc3ef6977b5f16d5222eb49b0ea49ad: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9f040a9884e2ae5b0f1409a3f9075c51c9: 8295278: Add parallel class loading tests
• 172006c0e9433046252bd79e8864890ab7c0ce56: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• 7743345f6f73398f280fd18364b4cea10a6b0f2f: 8294314: Minimize disabled warnings in hotspot
• 552d8a2821f03046896a728d6e4cec0ef754d3f4: 8295192: Use original configure command line when called from a script
• cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
• b3bb3e6ed89f3abcaae584fcbe75688141e886cb: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
• 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0: 8295110: RISC-V: Mark out relocations as incompressible
• 74a51ccc86525eb4b1eb2e5cb11e605ca9e9fc5d: 8292698: Improve performance of DataInputStream
• ... and 34 more: https://git.openjdk.org/jdk/compare/03e63a2b87e1bef6025722ec9a016312c55ebd81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @erikj79, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[luhenry]

/integrate

[openjdk[bot]]

@luhenry Your change (at version 8faf5083ac0b39f30263e1d819fc66c03e4ddd01) is now ready to be sponsored by a Committer.

[shipilev]

I think we want to ask @magicus about this as well, maybe he will discover some unusual quirks in this code. Otherwise, I'll sponsor.

[luhenry]

@magicus thanks! I committed your change.

[magicus]

If you redo /integrate, I can sponsor.

[luhenry]

/integrate

[openjdk[bot]]

@luhenry Your change (at version c78d2f021ad19cd601252aaeffbd3b844c4a9c78) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk[bot]]

Going to push as commit 4d37ef2d545c016e6c3ad52171ea961d4406726f. Since your change was applied there have been 44 commits pushed to the master branch:

• 0919a3a0c198a5234b5ed9a3bb999564d2382a56: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b83bc3ef6977b5f16d5222eb49b0ea49ad: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9f040a9884e2ae5b0f1409a3f9075c51c9: 8295278: Add parallel class loading tests
• 172006c0e9433046252bd79e8864890ab7c0ce56: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• 7743345f6f73398f280fd18364b4cea10a6b0f2f: 8294314: Minimize disabled warnings in hotspot
• 552d8a2821f03046896a728d6e4cec0ef754d3f4: 8295192: Use original configure command line when called from a script
• cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
• b3bb3e6ed89f3abcaae584fcbe75688141e886cb: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
• 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0: 8295110: RISC-V: Mark out relocations as incompressible
• 74a51ccc86525eb4b1eb2e5cb11e605ca9e9fc5d: 8292698: Improve performance of DataInputStream
• ... and 34 more: https://git.openjdk.org/jdk/compare/03e63a2b87e1bef6025722ec9a016312c55ebd81...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@shipilev @luhenry Pushed as commit 4d37ef2d545c016e6c3ad52171ea961d4406726f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.