8295000: java/util/Formatter/Basic test cleanup

[justin-curtis-lu]

Issue: java/util/Formatter/Basic regression test emits lots of warning messages (~60).

Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files where the errors originate from are generated from the template.

Note: The reason why there is white space added (and already existing in the BasicXXX files) is due to how the template is generated.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8295000: java/util/Formatter/Basic test cleanup

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10684/head:pull/10684
$ git checkout pull/10684

Update a local copy of the PR:
$ git checkout pull/10684
$ git pull https://git.openjdk.org/jdk pull/10684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10684

View PR using the GUI difftool:
$ git pr show -t 10684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10684.diff

[bridgekeeper[bot]]

:wave: Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (88ef21cc)
• 00: Full (026ca4c1)

[openjdk[bot]]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295000: java/util/Formatter/Basic test cleanup

Reviewed-by: bchristi, naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 907d583376dfab269ea25a6c036e390f3484065e: 8295323: Unnecessary HashTable usage in StyleSheet
• 2157145766f9789ade0940e9ae1715a3b74d508b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
• b8ad6cd98a7e4b577b888dc5f9d93c2e4d3bf177: 8294461: wrong effectively final determination by javac
• d6678952a6de4e5435dab65e7029021832454857: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
• 628820f47ef9c9ad3cc62e68db9c4dbc7e659154: 8283093: JMX connections should default to using an ObjectInputFilter
• 521e71222a8a01edcffedafb2d57c16aa070545c: 8286431: Do not use resource array in posix mmap_attach_shared()
• 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 210fe49e25da0ed6f3d3799ed253d9374568b89e: 6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel
• c2d7a35a4b3ec7d9c567cdd98c2db958c4b2e9d2: 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bchristi-git, @naotoj, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[justin-curtis-lu]

@LanceAndersen Thank you Lance,

I made the other changes we discussed, it is currently in a separate draft PR

[justin-curtis-lu]

/integrate

[openjdk[bot]]

@justin-curtis-lu Your change (at version 88ef21ccaa00ceaa7575cc8a99403949fbe960a7) is now ready to be sponsored by a Committer.

[naotoj]

/sponsor

[openjdk[bot]]

Going to push as commit 78763fc8e0d6940f1c85ff8705733b8e6ae8e945. Since your change was applied there have been 9 commits pushed to the master branch:

• 907d583376dfab269ea25a6c036e390f3484065e: 8295323: Unnecessary HashTable usage in StyleSheet
• 2157145766f9789ade0940e9ae1715a3b74d508b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
• b8ad6cd98a7e4b577b888dc5f9d93c2e4d3bf177: 8294461: wrong effectively final determination by javac
• d6678952a6de4e5435dab65e7029021832454857: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
• 628820f47ef9c9ad3cc62e68db9c4dbc7e659154: 8283093: JMX connections should default to using an ObjectInputFilter
• 521e71222a8a01edcffedafb2d57c16aa070545c: 8286431: Do not use resource array in posix mmap_attach_shared()
• 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 210fe49e25da0ed6f3d3799ed253d9374568b89e: 6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel
• c2d7a35a4b3ec7d9c567cdd98c2db958c4b2e9d2: 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@naotoj @justin-curtis-lu Pushed as commit 78763fc8e0d6940f1c85ff8705733b8e6ae8e945.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.