8295118: G1: Clear CLD claim marks concurrently

[tschatzl]

Hi all,

can I have reviews for this change that moves out clearing CLD marks from the concurrent start pause to the concurrent phase?

The idea is that instead of clearing CLD marks just before marking through, clear the marks at the end of the concurrent phases (or at the end of the full gc) so that after that operation marks are reset.

I believe that one can save one of the ClassLoaderDataGraph::clear_claimed_marks in full gc by using different claim values (we need the one at the beginning and the end though), but the overhead of that should be minimal compared to actual full gc time.

Testing: tier1-5

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8295118: G1: Clear CLD claim marks concurrently

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10675/head:pull/10675
$ git checkout pull/10675

Update a local copy of the PR:
$ git checkout pull/10675
$ git pull https://git.openjdk.org/jdk pull/10675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10675

View PR using the GUI difftool:
$ git pr show -t 10675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10675.diff

[bridgekeeper[bot]]

:wave: Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (c15f0a73)
• 03: Full - Incremental (be0b9cf3)
• 02: Full - Incremental (293d3af3)
• 01: Full - Incremental (4d12b230)
• 00: Full (2c2ce57e)

[openjdk[bot]]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295118: G1: Clear CLD claim marks concurrently

Reviewed-by: iwalulya, sjohanss, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 180 new commits pushed to the master branch:

• f37a6055c469956a1e69715840a61f56b5cea425: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd857722d117b108590ba7f7c02f8622fc3b: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7508af58f7ed669bde4820ec9f80f58607: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
• 7520d0a72573ebaec0b6d9f9f1f1d87688bff8c0: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5cdd698045ab9c285c92b96126ed0666ac5: 8295716: Minimize disabled warnings in security libs
• 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
• e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• df81b3c66a3b17fc5d10098ce879416affbddd40: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java
• 68cf248b440a09c4d9bd16c862473f6a97cde279: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• ... and 170 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Another tier1-5 run seems okay.

Thanks @walulyai @albertnetymk @kstefanj for your reviews.

/integrate

[openjdk[bot]]

Going to push as commit 5c4d99a05185cc5fc41691fd62102f3b5bbefc50. Since your change was applied there have been 182 commits pushed to the master branch:

• af2de975cbc46ad91c736b110a2212cd32ba60a7: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
• 9051dded84ef2d248483a6a1472def1eab79654f: 8294993: LingeredApp test update
• f37a6055c469956a1e69715840a61f56b5cea425: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd857722d117b108590ba7f7c02f8622fc3b: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7508af58f7ed669bde4820ec9f80f58607: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
• 7520d0a72573ebaec0b6d9f9f1f1d87688bff8c0: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5cdd698045ab9c285c92b96126ed0666ac5: 8295716: Minimize disabled warnings in security libs
• 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
• e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• ... and 172 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@tschatzl Pushed as commit 5c4d99a05185cc5fc41691fd62102f3b5bbefc50.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.