jdk
jdk copied to clipboard
openjdk
8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java
Issue: Resource bundle name does not follow proper naming conventions according to getBundle method for base name parameter
Fix: Modified bundle name to be a fully qualified class and added regression tests.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10612/head:pull/10612
$ git checkout pull/10612
Update a local copy of the PR:
$ git checkout pull/10612
$ git pull https://git.openjdk.org/jdk pull/10612/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10612
View PR using the GUI difftool:
$ git pr show -t 10612
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10612.diff
:wave: Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@justin-curtis-lu The following label will be automatically applied to this pull request:
-
core-libs
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 12: Full - Incremental (da3aeacd)
- 11: Full - Incremental (0f503392)
- 10: Full - Incremental (8f0b6ac6)
- 09: Full - Incremental (2e39c411)
- 08: Full - Incremental (2ea3e423)
- 07: Full - Incremental (1aa881bc)
- 06: Full - Incremental (0aa978cb)
- 05: Full - Incremental (c67d789c)
- 04: Full - Incremental (c86950b1)
- 03: Full - Incremental (3e49163b)
- 02: Full - Incremental (1ce2671c)
- 01: Full - Incremental (646ee97a)
- 00: Full (609a6d07)
btw, the link to getBundle javadoc points to JDK8's, where the module has not yet been introduced. I was scratching my head why I couldn't find the overload that takes a Module 😀
btw, the link to getBundle javadoc points to JDK8's, where the module has not yet been introduced. I was scratching my head why I couldn't find the overload that takes a Module 😀
I intended to focus on "baseName - the base name of the resource bundle, a fully qualified class name" but you're right, will replace with a doc that is up to date with the code, thank you.
@justin-curtis-lu This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java
Reviewed-by: naoto, lancea, bchristi
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 270 new commits pushed to the master branch:
- 427f50624f9f60bb3502227fd04a04991986329c: 8279366: CDS should allow alternative locations for JAR files in classpath
- 3a873d3c5b2281b2389e9364ff26f04ee86b0607: 8295808: GrowableArray should support capacity management
- 6289600fe86bf1f8de160ea64cdba960b2d3e693: 8295810: cleanup debug agent removeThread() api
- 5c4d99a05185cc5fc41691fd62102f3b5bbefc50: 8295118: G1: Clear CLD claim marks concurrently
- af2de975cbc46ad91c736b110a2212cd32ba60a7: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
- 9051dded84ef2d248483a6a1472def1eab79654f: 8294993: LingeredApp test update
- f37a6055c469956a1e69715840a61f56b5cea425: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
- 6673cd857722d117b108590ba7f7c02f8622fc3b: 8295554: Move the "sizecalc.h" to the correct location
- 706d1b7508af58f7ed669bde4820ec9f80f58607: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
- 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
- ... and 260 more: https://git.openjdk.org/jdk/compare/f2c57186a40bea4d5ad1c3ba010b59e552db624d...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @LanceAndersen, @bchristi-git) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@justin-curtis-lu Your change (at version da3aeacda83767ba9fd898eb3f63c66c0332062e) is now ready to be sponsored by a Committer.
Going to push as commit d393e051e660d05b645a2d148c6cdfc21b1d347e.
Since your change was applied there have been 274 commits pushed to the master branch:
- 0caea818b59f7e2cd60708b1002fba328c5357fe: 8295895: build error after JDK-8279366
- ee0dec8bf5cae1c3c39ea14d306d62dd39dac208: 8295838: Document why we do not print Code Cache Roots phase in G1 logging
- ef606086a94cab4a41e4bec9f91b420094a7acad: 8295732: Directly embed TruncatedSeqs in G1Analytics
- 3e49f8fd28590116e245faffe1c467371be6f43e: 8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs
- 427f50624f9f60bb3502227fd04a04991986329c: 8279366: CDS should allow alternative locations for JAR files in classpath
- 3a873d3c5b2281b2389e9364ff26f04ee86b0607: 8295808: GrowableArray should support capacity management
- 6289600fe86bf1f8de160ea64cdba960b2d3e693: 8295810: cleanup debug agent removeThread() api
- 5c4d99a05185cc5fc41691fd62102f3b5bbefc50: 8295118: G1: Clear CLD claim marks concurrently
- af2de975cbc46ad91c736b110a2212cd32ba60a7: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
- 9051dded84ef2d248483a6a1472def1eab79654f: 8294993: LingeredApp test update
- ... and 264 more: https://git.openjdk.org/jdk/compare/f2c57186a40bea4d5ad1c3ba010b59e552db624d...master
Your commit was automatically rebased without conflicts.
@naotoj @justin-curtis-lu Pushed as commit d393e051e660d05b645a2d148c6cdfc21b1d347e.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.