jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8294752: G1: Remove redundant checks in check_obj_during_refinement

Open albertnetymk opened this issue 2 years ago • 4 comments

Simple change of removing redundant assertions.

Test: hotspot_gc


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8294752: G1: Remove redundant checks in check_obj_during_refinement

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10551/head:pull/10551
$ git checkout pull/10551

Update a local copy of the PR:
$ git checkout pull/10551
$ git pull https://git.openjdk.org/jdk pull/10551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10551

View PR using the GUI difftool:
$ git pr show -t 10551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10551.diff

albertnetymk avatar Oct 04 '22 09:10 albertnetymk

:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 04 '22 09:10 bridgekeeper[bot]

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 04 '22 09:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 04 '22 09:10 mlbridge[bot]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294752: G1: Remove redundant checks in check_obj_during_refinement

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 299 new commits pushed to the master branch:

  • af2de975cbc46ad91c736b110a2212cd32ba60a7: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 9051dded84ef2d248483a6a1472def1eab79654f: 8294993: LingeredApp test update
  • f37a6055c469956a1e69715840a61f56b5cea425: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
  • 6673cd857722d117b108590ba7f7c02f8622fc3b: 8295554: Move the "sizecalc.h" to the correct location
  • 706d1b7508af58f7ed669bde4820ec9f80f58607: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
  • 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
  • 7520d0a72573ebaec0b6d9f9f1f1d87688bff8c0: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
  • 1d15e5cdd698045ab9c285c92b96126ed0666ac5: 8295716: Minimize disabled warnings in security libs
  • 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
  • e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
  • ... and 289 more: https://git.openjdk.org/jdk/compare/090cdfc7a2e280c620a0926512fb67f0ce7f3c21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 05 '22 09:10 openjdk[bot]

Thanks for the review.

/integrate

albertnetymk avatar Oct 26 '22 09:10 albertnetymk

Going to push as commit 303548babc67be0850c47b60315714b106c0a0ee. Since your change was applied there have been 317 commits pushed to the master branch:

  • cf121df17e60df61a1b8825724c0d735f11e73f6: 8295889: NMT preinit code does not handle allocation errors
  • 772be2e02b7bb1089116c0debb514154489cfa81: 8295868: 32-bit Windows build failures after JDK-8294466
  • e173fd792216940652efca4c2db26fc8d23931f8: 8295885: GHA: Bump gcc versions
  • b2878c904beb971da37b1da50a7294c460d6cef3: 8295710: remove os::dll_file_extension
  • e3a5a34c4d18375a310212da2e52a8ad85a3f556: 8295767: Remove unused fields in sun.awt.geom.Edge
  • 324bec19aa9b9d4944a7e1129d494d57a077ba51: 8295863: JFR: Use expected size for Maps and Sets
  • 3bd3caf897dcb6d53fae6e94ba1cc281b30277ea: 8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.
  • fec61746d1b9e3143fe64e9604732207b0a8c643: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • e0c29307f7b35149aacae0bb935aa9fe524cff72: 8295282: Use Zicboz/cbo.zero to zero-out memory on RISC-V
  • d393e051e660d05b645a2d148c6cdfc21b1d347e: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java
  • ... and 307 more: https://git.openjdk.org/jdk/compare/090cdfc7a2e280c620a0926512fb67f0ce7f3c21...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 26 '22 09:10 openjdk[bot]

@albertnetymk Pushed as commit 303548babc67be0850c47b60315714b106c0a0ee.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 26 '22 09:10 openjdk[bot]