8295323: Unnecessary HashTable usage in StyleSheet

[turbanoff]

Hashtable was used only from single thread. And only non-null key/values added to it. We can safely replace it with HashSet.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8295323: Unnecessary HashTable usage in StyleSheet

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10522/head:pull/10522
$ git checkout pull/10522

Update a local copy of the PR:
$ git checkout pull/10522
$ git pull https://git.openjdk.org/jdk pull/10522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10522

View PR using the GUI difftool:
$ git pr show -t 10522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10522.diff

[bridgekeeper[bot]]

:wave: Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (f89a85c4)
• 00: Full (ee8cbfd5)

[openjdk[bot]]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295323: Unnecessary HashTable usage in StyleSheet

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 312 new commits pushed to the master branch:

• 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
• 7520d0a72573ebaec0b6d9f9f1f1d87688bff8c0: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5cdd698045ab9c285c92b96126ed0666ac5: 8295716: Minimize disabled warnings in security libs
• 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
• e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• df81b3c66a3b17fc5d10098ce879416affbddd40: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java
• 68cf248b440a09c4d9bd16c862473f6a97cde279: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• fefbddf83595c15bbfd110a59e718ebf9f79b554: 8291443: Obsolete the PrintSharedDictionary flag
• 5b3de6e143e370272c36383adac3e31f359bc686: 8284840: Update CLDR to Version 42.0
• 2f3f3b618500b5f112fabca30d4c6780b2a8e723: 8295792: Clean up old async close code
• ... and 302 more: https://git.openjdk.org/jdk/compare/b8b9b97a1a3e07777da2e39ac4779ef7b77434c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[turbanoff]

So I think this is OK, but please be sure you have run at least the related Swing jtreg tests

Run tests from test/jdk/javax/swing/text. All green.

[turbanoff]

/integrate

[openjdk[bot]]

Going to push as commit 907d583376dfab269ea25a6c036e390f3484065e. Since your change was applied there have been 351 commits pushed to the master branch:

• 2157145766f9789ade0940e9ae1715a3b74d508b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
• b8ad6cd98a7e4b577b888dc5f9d93c2e4d3bf177: 8294461: wrong effectively final determination by javac
• d6678952a6de4e5435dab65e7029021832454857: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
• 628820f47ef9c9ad3cc62e68db9c4dbc7e659154: 8283093: JMX connections should default to using an ObjectInputFilter
• 521e71222a8a01edcffedafb2d57c16aa070545c: 8286431: Do not use resource array in posix mmap_attach_shared()
• 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 210fe49e25da0ed6f3d3799ed253d9374568b89e: 6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel
• c2d7a35a4b3ec7d9c567cdd98c2db958c4b2e9d2: 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out
• 58a7141a0dea5d1b4bfe6d56a95d860c854b3461: 8295066: Folding of loads is broken in C2 after JDK-8242115
• a8450b37ee6ea83c5354ba0892ac71df19e5a1cc: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows
• ... and 341 more: https://git.openjdk.org/jdk/compare/b8b9b97a1a3e07777da2e39ac4779ef7b77434c7...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@turbanoff Pushed as commit 907d583376dfab269ea25a6c036e390f3484065e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.