jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8292177: InitialSecurityProperty JFR event

Open coffeys opened this issue 2 years ago • 6 comments

New JFR event to record state of initial security properties.

Debug output is also now added for these properties via -Djava.security.debug=properties

Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10394/head:pull/10394
$ git checkout pull/10394

Update a local copy of the PR:
$ git checkout pull/10394
$ git pull https://git.openjdk.org/jdk pull/10394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10394

View PR using the GUI difftool:
$ git pr show -t 10394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10394.diff

coffeys avatar Sep 22 '22 15:09 coffeys

:wave: Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 22 '22 16:09 bridgekeeper[bot]

@coffeys The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-jfr
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Sep 22 '22 16:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 22 '22 16:09 mlbridge[bot]

Hello Sean,

Debug output is also now added for these properties via -Djava.security.debug=properties

Looking at the existing code upstream, it appears that the value properties is already recognized for java.security.debug system property. So it's not something this PR is introducing/proposing. However, the documentation for this system property doesn't seem to be listing that as a value https://docs.oracle.com/en/java/javase/19/security/troubleshooting-security.html. Do you think that documentation would need to be addressed (as a separate issue)?

jaikiran avatar Sep 28 '22 07:09 jaikiran

Hello Sean,

Debug output is also now added for these properties via -Djava.security.debug=properties

Looking at the existing code upstream, it appears that the value properties is already recognized for java.security.debug system property. So it's not something this PR is introducing/proposing. However, the documentation for this system property doesn't seem to be listing that as a value https://docs.oracle.com/en/java/javase/19/security/troubleshooting-security.html. Do you think that documentation would need to be addressed (as a separate issue)?

Good point Jai. It's a rarely used property value I guess, but it would be exposed via the "all" debug value option as per test. I suspect there may be other such properties also. I'll log a JBS issue to track this and to have security/docs team discuss.

coffeys avatar Sep 28 '22 10:09 coffeys

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292177: InitialSecurityProperty JFR event

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the master branch:

  • 21407dec0156301871a83328615e4d975c4287c4: 8295173: (tz) Update Timezone Data to 2022e
  • f5f8df11ce146f8b33963eea4de6ccf9d2373ff3: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
  • 18dd9ee7010cc4c2ded24042049e94d3f775a785: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
  • 4224d45132b98e4f7bb7a96b696692d2f0bf645e: 8295232: "java.locale.useOldISOCodes" property is read lazily
  • 3b3438752cbac49272dfda7d11adbeac0ab2ea9d: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB
  • c7f65438bb4a4fd449bd19b68574cfa4b42d7ca8: 8295223: JFR: At most one native periodic event thread at a time
  • 7e4868de7b0d3c20a35f06671ec0b68cfd441793: 8294847: Fix calculation of G1 effective scanned cards prediction
  • 2f60675e06801b8ee495729d8bff2faec37ce509: 8294997: Improve ECC math operations
  • 94caecbe574227b232e22d9f56361f8ecd507be6: 8294906: Memory leak in PKCS11 NSS TLS server
  • 03e63a2b87e1bef6025722ec9a016312c55ebd81: 8295225: [JVMCI] codeStart should be cleared when entryPoint is cleared
  • ... and 117 more: https://git.openjdk.org/jdk/compare/3644e26cef71c00e1a2638d2b8bed9c1bda965ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 06 '22 17:10 openjdk[bot]

/integrate

coffeys avatar Oct 18 '22 11:10 coffeys

Going to push as commit 8c40b7dc8cd7b6a6d0c9349b991e0e01b69349c3. Since your change was applied there have been 181 commits pushed to the master branch:

  • e7a964b4dbbdd21eba87dc94eb3680e9553f5039: 8295268: Optimized builds are broken due to incorrect assert_is_rfp shortcuts
  • 0b7d811c98cb45a822b7ef56e5ee99d1b5483e78: 8294730: Add @throws and @implNote clauses to BigInteger::isProblablePrime and BigInteger::nextProblablePrime
  • 4434cbb719db37880b48474ba342f300ed4828a8: 8295264: Fix PaX check on RISC-V
  • a8c18ebc152842281b22534507b4a09612ea3498: 8295257: Remove implicit noreg temp register arguments in aarch64 MacroAssembler
  • 6553065cab9ecb14390da8ec34e49aba940b213f: 8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv
  • b06f1b149c8f8a49d4e42c4b782a4b3a22aa79f6: 8294594: Fix cast-function-type warnings in signal handling code
  • 71aa8210910dbafe30eccc772eaa7747f46be0cd: 8295176: some langtools test pollutes source tree
  • bca7ab3c1109e6cff9b50ecdd3045cb0ae8f6953: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • c33ca0c5edd60454c58916cb588e5b2cfcc7b36a: 6229853: BasicTextAreaUI:create incompletely documents the possible returned View types
  • 358ac07255cc640cbcb9b0df5302d97891a34087: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • ... and 171 more: https://git.openjdk.org/jdk/compare/3644e26cef71c00e1a2638d2b8bed9c1bda965ca...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 18 '22 11:10 openjdk[bot]

@coffeys Pushed as commit 8c40b7dc8cd7b6a6d0c9349b991e0e01b69349c3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 18 '22 11:10 openjdk[bot]