jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8245654: Add Certigna Root CA

Open rhalade opened this issue 2 years ago • 8 comments

This fix adds Certigna root CA to cacerts trust store.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10030/head:pull/10030
$ git checkout pull/10030

Update a local copy of the PR:
$ git checkout pull/10030
$ git pull https://git.openjdk.org/jdk pull/10030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10030

View PR using the GUI difftool:
$ git pr show -t 10030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10030.diff

rhalade avatar Aug 25 '22 16:08 rhalade

:wave: Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 25 '22 16:08 bridgekeeper[bot]

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Aug 25 '22 16:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 25 '22 20:08 mlbridge[bot]

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245654: Add Certigna Root CA

Reviewed-by: xuelei, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 3baad069a65a0ac138a6aaabf451758672d12fbc: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c048eaabdf4ef3a891cc4bd232d69fc4631: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574ebc32fa0e62dbaa0f2447757ff83c320f: 8296137: diags-examples.xml is broken
  • 00d22f605d2b54f2774aeaa1edfbb146a5635f21: 8279164: Disable TLS_ECDH_* cipher suites
  • d634ddefdd7712f4c3ac070d8493be5ba2de2aef: 8295354: Remove G1 incremental non-copy time calculation
  • 8836b92593565e66d8063b1228d6701316f3078d: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
  • 51f8e9b0e127739e36f2d9136bd1618be7d828b7: 8296443: NMT: Remove cmdline_tracking_level handling code
  • 087cedc080963f027306f9d4c4ab737ddf42a5bc: 8295261: RISC-V: Support ReductionV instructions for Vector API
  • 556377a0583b519ac191675c2b078f1a2efe2f72: 8296270: Memory leak in ClassLoader::setup_bootstrap_search_path_impl
  • c2f76383895e3d054988a5817de52e7795bf69c2: 8296335: Fix accessibility manual test instruction
  • ... and 59 more: https://git.openjdk.org/jdk/compare/50d91a31d495adf8e189d0188918f4ff22f93876...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 26 '22 04:08 openjdk[bot]

Can we change the issue title to "Add Certigna Root CA" since only one root is being added?

seanjmullan avatar Aug 26 '22 13:08 seanjmullan

I have update the bug summary as suggested by Sean.

rhalade avatar Aug 26 '22 16:08 rhalade

I put this on hold to debug a potential issue I am seeing.

rhalade avatar Aug 26 '22 18:08 rhalade

@rhalade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 27 '22 19:09 bridgekeeper[bot]

Hi @lilgallon, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user lilgallon for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

lilgallon avatar Oct 17 '22 16:10 lilgallon

I am closing this pull request as we still don't have OCA signed from CA.

rhalade avatar Nov 07 '22 17:11 rhalade