jcstress
jcstress copied to clipboard
openjdk
7903750: TimeBudget (-tb) does not fulfill its promisses
Added warning, when time budget is to small, and final run will run at least two times longer.
Progress
- [x] Change must not contain extraneous whitespace
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- CODETOOLS-7903750: TimeBudget (-tb) does not fulfill its promisses (Bug - P4)
Reviewers
- Galder Zamarreño (@galderz - no project role)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/161/head:pull/161
$ git checkout pull/161
Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jcstress.git pull/161/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 161
View PR using the GUI difftool:
$ git pr show -t 161
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/161.diff
Using Webrev
:wave: Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
Webrevs
- 07: Full - Incremental (cbedff70)
- 06: Full - Incremental (7b68f54b)
- 05: Full - Incremental (a5d54a41)
- 04: Full - Incremental (8e42d2a4)
- 03: Full - Incremental (3d002c0d)
- 02: Full - Incremental (d4ec90db)
- 01: Full - Incremental (14913a31)
- 00: Full (8e5b39a5)
hi @galderz ! TYVM for eyeball! I had adjusted to all of your comments, and left few question marks. Hope that is ok. thank you again! (If I missed any, it was not intentional)
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.