7903266: jcstress: Filter debugger options from command-line autodetection

[jerzykrlk]

When I tried to debug jcstress, it wouldn't start. After a while it turned out that the JVM arguments were all passed over while looking for available JVM configs - including the debug parameter and a fixed debug port.

This one simplifies debugging jcstress internals. Or, is there a more elegant way to debug?

Thank you!

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ OCA signatory status must be verified

Issue

• CODETOOLS-7903266: jcstress: Filter debugger options from command-line autodetection (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Committer) ⚠️ Review applies to 4feef7fb

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jcstress.git pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/119.diff

[bridgekeeper[bot]]

Hi @jerzykrlk, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jerzykrlk" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[jerzykrlk]

/signed

[bridgekeeper[bot]]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[jerzykrlk]

Ok, thank you. Fixed.

[jerzykrlk]

Thank you.

I'll just submit another OCA. It's been 5 years - last time it was Mercurial repo.

[shipilev]

I'll just submit another OCA. It's been 5 years - last time it was Mercurial repo.

No need yet, try to hook up your GH username to existing OCA. It would be much easier.

[jerzykrlk]

/signed

[bridgekeeper[bot]]

Already processed the signed command

[jerzykrlk]

Good afternoon. I've already submitted the 2nd OCA some time ago. Has it been reviewed already?

[shipilev]

Good afternoon. I've already submitted the 2nd OCA some time ago. Has it been reviewed already?

We need to ask @robilad about this. Hey, Dalibor!

[jerzykrlk]

I'm a bit worried - I already pinged @robilad in December to his Oracle mailbox. And a general Oracle mailbox, too.

Is there anyone else I could contact?

[shipilev]

I'm a bit worried - I already pinged @robilad in December to his Oracle mailbox. And a general Oracle mailbox, too.

Is there anyone else I could contact?

Do you have the OpenJDK account (i.e. one that can be used at bugs.openjdk.net)? If so, I think it would be much easier to hook up your GitHub name to existing OCA / census name, like: https://bugs.openjdk.org/browse/SKARA-608

I wrote a personal email to Dalibor to see what can we do here.

[jerzykrlk]

Hi Aleksey.

I mailed Dalibor early December, too. I'm just a contributor, without an OpenJDK account. I had a quick look and I can't just register in the OpenJDK JIRA.

I mailed the 'contact us' OpenJDK address, though. Maybe this helps.

[openjdk[bot]]

@jerzykrlk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@jerzykrlk this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-debug-parameter-from-vm-detection
git fetch https://git.openjdk.org/jcstress master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[jerzykrlk]

Good evening Aleksey,

Maybe it'll be easier to create an OpenJDK JIRA account? I've had a look at https://wiki.openjdk.org/display/general/JBS+Overview#JBSOverview-AccountEligibility - but it doesn't seem that easy. Do you have superpowers to do so?

[bridgekeeper[bot]]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@jerzykrlk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[shipilev]

/open

[shipilev]

@jerzykrlk, have you got any luck resolving your OCA status?

[openjdk[bot]]

@shipilev Only the pull request author can set the pull request state to "open"

[jerzykrlk]

/open

[openjdk[bot]]

@jerzykrlk This pull request is now open

[jerzykrlk]

@shipilev No luck, really. I've sent an email to Oracle and went to JCrete - nothing helped. Maybe you know the way?

[shipilev]

Let's try @robilad again! Dalibor, can you look into this?

[bridgekeeper[bot]]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Not now, bot.

[bridgekeeper[bot]]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Not now, bot.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.