jcstress icon indicating copy to clipboard operation
jcstress copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

7903265: jcstress: Drop the mention of embedded mode from command line options

Open jerzykrlk opened this issue 3 years ago • 33 comments
trafficstars

Good evening!

I realized that the 'fork=0' mode was removed from jcstress some time ago, but it was still documented in the command line as an 'embedded mode'.

Here's the updated command line.

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ OCA signatory status must be verified

Issue

  • CODETOOLS-7903265: jcstress: Drop the mention of embedded mode from command line options (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.org/jcstress.git pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/118.diff

jerzykrlk avatar Aug 25 '22 20:08 jerzykrlk

Hi @jerzykrlk, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jerzykrlk" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar Aug 25 '22 20:08 bridgekeeper[bot]

Hello again.

It took a while to debug and find the root cause.

Would you be able to check a PR which simplified debugging jcstress a bit? It's here: https://github.com/openjdk/jcstress/pull/119

Thank you!

jerzykrlk avatar Aug 25 '22 20:08 jerzykrlk

/signed

jerzykrlk avatar Aug 25 '22 20:08 jerzykrlk

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar Aug 25 '22 20:08 bridgekeeper[bot]

Please also go to https://github.com/jerzykrlk/jcstress/actions -- and press the button authorizing the testing workflows to run.

shipilev avatar Aug 26 '22 08:08 shipilev

Good morning.

I signed OCA a long time ago and I'm listed here: https://oca.opensource.oracle.com/?ojr=contrib-list (name: Jerzy Krolak) - should I sign again?

Thanks.

jerzykrlk avatar Aug 26 '22 09:08 jerzykrlk

I signed OCA a long time ago and I'm listed here: https://oca.opensource.oracle.com/?ojr=contrib-list (name: Jerzy Krolak) - should I sign again?

I think you need to hook up your GitHub account name to that submitted, as the message above says:

"If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jerzykrlk" as summary for the issue."

shipilev avatar Aug 26 '22 09:08 shipilev

I'm sorry, I didn't want to bother you with this boring stuff on Friday evening.

I think I don't have the JIRA account. Maybe Contributor != Author.

Never mind - I submitted the new OCA. Thanks and have a great weekend.

jerzykrlk avatar Aug 26 '22 16:08 jerzykrlk

/signed

jerzykrlk avatar Aug 26 '22 16:08 jerzykrlk

Already processed the signed command

bridgekeeper[bot] avatar Aug 26 '22 16:08 bridgekeeper[bot]

/signed

jerzykrlk avatar Sep 12 '22 15:09 jerzykrlk

Already processed the signed command

bridgekeeper[bot] avatar Sep 12 '22 15:09 bridgekeeper[bot]

Well, we can ask @robilad about this, but I think it would be easier to just hook your username: https://github.com/openjdk/jcstress/pull/118#issuecomment-1228288109

shipilev avatar Sep 12 '22 17:09 shipilev

Ok, this might sound silly - but how do I get an account there? I think I never had an account, and I can't register myself.

Thanks!

jerzykrlk avatar Sep 12 '22 19:09 jerzykrlk

Ok, this might sound silly - but how do I get an account there? I think I never had an account, and I can't register myself.

Oh, I understand. You are not an OpenJDK Author, so this pathway does not apply to you. Let's wait for @robilad to process the OCA then...

shipilev avatar Sep 13 '22 10:09 shipilev

@jerzykrlk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

openjdk[bot] avatar Feb 17 '23 18:02 openjdk[bot]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Dec 04 '23 19:12 bridgekeeper[bot]

@jerzykrlk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jan 02 '24 03:01 bridgekeeper[bot]

/open

shipilev avatar Jan 08 '24 12:01 shipilev

@shipilev Only the pull request author can set the pull request state to "open"

openjdk[bot] avatar Jan 08 '24 12:01 openjdk[bot]

/open

jerzykrlk avatar Jan 08 '24 16:01 jerzykrlk

@jerzykrlk This pull request is now open

openjdk[bot] avatar Jan 08 '24 16:01 openjdk[bot]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 05 '24 19:02 bridgekeeper[bot]

Not now, bot. Dalibor is figuring out OCA stuff.

shipilev avatar Feb 06 '24 09:02 shipilev

Hello Aleksey. Is there a chance I can help with the OCA in any way?

jerzykrlk avatar Feb 12 '24 20:02 jerzykrlk

Hello Aleksey. Is there a chance I can help with the OCA in any way?

I don't think so, we just need to wait. Sorry for delay!

shipilev avatar Feb 13 '24 07:02 shipilev

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 12 '24 10:03 bridgekeeper[bot]

Not, now, bot.

shipilev avatar Mar 12 '24 12:03 shipilev

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@jerzykrlk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '24 02:04 bridgekeeper[bot]