crac
crac copied to clipboard
8353241: [CRaC] Support ZGC
During my tests with https://github.com/CRaC/example-spring-boot I could not get the image size as low as with G1, but the presented changes improve the image footprint. As as anecdotal data, the image is 177 MB with G1 while 215 MB with ZGC (fastdebug build, -Xmx1G).
Progress
- [x] Change must not contain extraneous whitespace
Issue
- JDK-8353241: [CRaC] Support ZGC (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/219/head:pull/219
$ git checkout pull/219
Update a local copy of the PR:
$ git checkout pull/219
$ git pull https://git.openjdk.org/crac.git pull/219/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 219
View PR using the GUI difftool:
$ git pr show -t 219
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/219.diff
Using Webrev
:wave: Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@rvansa This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8353241: [CRaC] Support ZGC
Reviewed-by: tpushkin
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 2 new commits pushed to the crac branch:
- d64fb30c0874d93c986ad04ac3995a727b7a1ac8: 8354514: [CRaC] Remove new methods from AbstractInterruptibleChannel and SocketImpl
- ad63687e9a057517831af62c60275684bc668e3e: 8354432: [CRaC] Timed waiting finishes early w.r.t. wall clock time
Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.
Webrevs
- 03: Full - Incremental (3b7d15e7)
- 02: Full (75e2bc41)
- 01: Full - Incremental (3aabf07c)
- 00: Full (1f46d9eb)
Conflicts resolved.
My review ETA: next week
Updated.
/integrate
Going to push as commit 647105388b66b7acedf03d049dc60323912a8fe7.
Since your change was applied there have been 2 commits pushed to the crac branch:
- d64fb30c0874d93c986ad04ac3995a727b7a1ac8: 8354514: [CRaC] Remove new methods from AbstractInterruptibleChannel and SocketImpl
- ad63687e9a057517831af62c60275684bc668e3e: 8354432: [CRaC] Timed waiting finishes early w.r.t. wall clock time
Your commit was automatically rebased without conflicts.
@rvansa Pushed as commit 647105388b66b7acedf03d049dc60323912a8fe7.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.