babylon Replace the use of Interpreter to create Quoted instance with specialized code

Creating Quoted instance was done by invoking the Interpreter. The Interpreter is too general and if someone could somehow inject any code model we will interpret that as well. This PR replace the use of the interpreter with specialized code.

Progress

[x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/424/head:pull/424
$ git checkout pull/424

Update a local copy of the PR:
$ git checkout pull/424
$ git pull https://git.openjdk.org/babylon.git pull/424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 424

View PR using the GUI difftool:
$ git pr show -t 424

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/424.diff

Using Webrev

Link to Webrev Comment

May 12 '25 15:05 mabbay

:wave: Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

May 12 '25 15:05 bridgekeeper[bot]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Replace the use of Interpreter to create Quoted instance with specialized code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

May 12 '25 15:05 openjdk[bot]

Webrevs

May 12 '25 15:05 mlbridge[bot]

@mabbay Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

May 22 '25 23:05 openjdk[bot]

@mabbay this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout quoted-instance-creation
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

Jun 16 '25 13:06 openjdk[bot]

/integrate

Jun 26 '25 15:06 mabbay

Going to push as commit bcad7e6b29b1a968d5e0e4acb4f3728a86d1ca44.

Jun 26 '25 15:06 openjdk[bot]

@mabbay Pushed as commit bcad7e6b29b1a968d5e0e4acb4f3728a86d1ca44.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Jun 26 '25 15:06 openjdk[bot]

babylon babylon copied to clipboard

Replace the use of Interpreter to create Quoted instance with specialized code

Progress

Reviewing

Webrevs

babylon
babylon copied to clipboard