openiddict-core
openiddict-core copied to clipboard
openiddict
Add telemetry support
Is your feature request related to a problem?
Not really a problem but a difficulty in primarly understanding performance behaviour but also lack of tracing ability of middleware.
Describe the solution you'd like
Hi, have there been any thoughts on adding some kind of telemetry support? If so are there any technical reasons for not wanting to add such support from your point of view? Do you see a future need for such a thing? If one would at some point try to add such a thing would it be taken into considerstion?
Additional context
I think it is a great idea but I would wait until events in Open Telemetry are stable. Should be this year.
I think it is a great idea but I would wait until events in Open Telemetry are stable. Should be this year.
Just curious, what do you mean by stable? What issues would hinder this and in what way? @SebastianStehle
If so are there any technical reasons for not wanting to add such support from your point of view?
Like most things, the reason is actually simpler: because you're the first one asking for it 😄 It's a good idea but I'm not super familiar with the new diagnostics/telemetry APIs introduced in recent .NET versions so it's not going to be a quick thing to implement.
If so are there any technical reasons for not wanting to add such support from your point of view?
Like most things, the reason is actually simpler: because you're the first one asking for it 😄
It's a good idea but I'm not super familiar with the new diagnostics/telemetry APIs introduced in recent .NET versions so it's not going to be a quick thing to implement.
Im learning as much as i can on those APIs so im not any expert by any means but i just mainly wanted to see whether or not it would be a waste of time to contribute something or atleast a naive prototype on this topic 🙂
But it sounds like its an not that farfetched idea then 👍
Just curious, what do you mean by stable? What issues would hinder this and in what way? @SebastianStehle
Open Telemetry has several components:
- Tracing
- Metrics / Events
- Logs
Only tracing is ready, but when you go over the code it makes sense to introduce a few events as well. Therefore I would implement it in one step.
Just curious, what do you mean by stable? What issues would hinder this and in what way? @SebastianStehle
Open Telemetry has several components:
Tracing
Metrics / Events
Logs
Only tracing is ready, but when you go over the code it makes sense to introduce a few events as well. Therefore I would implement it in one step.
Thank you for the clarification. Sounds like a reasonsble approach 👍
Honestly I would also like this, my traces are missing a couple of jumps showing for introspection...
Any updates on the possibility of implementing opentelemetry traces and metrics?
No immediate plans (since no one offered to fund that). That said, there's a demand, so maybe in the future.