php-openid icon indicating copy to clipboard operation
php-openid copied to clipboard

Bug Auth_OpenID::parse_str ignores values that contain '='

Open coverprice opened this issue 12 years ago • 1 comments

If the parameter value contains an '=' sign, the parameter is ignored.

e.g. Auth_OpenID::parse_str('foo=xxxx=&baz=yyyy') will skip the 'foo' parameter because its value has a trailing '='.

This causes problems when some values are base64 encoded, because they may contain '=' symbols.

The solution is the following: Auth/OpenID.php line 275: old: $pair = explode('=', $parts[$i]); new: $pair = explode('=', $parts[$i], 2);

coverprice avatar Oct 19 '12 02:10 coverprice

Please consider forking the repository, amending the fix, committing and pushing, then opening a Pull Request to have this included.

marcoceppi avatar Oct 19 '12 02:10 marcoceppi

This repo is being archived. Closing issue.

timcappalli avatar Jul 24 '23 18:07 timcappalli