php-openid icon indicating copy to clipboard operation
php-openid copied to clipboard

SQLStore still makes use of PEAR DB

Open ccazette opened this issue 14 years ago • 1 comments

It is clearly stated in the class comments that PEAR can be replaced with a class extending DatabaseConnection. This is for good, I don't have PEAR installed on my system and don't want to install it. However, SQLStore still uses PEAR : function isError($value) { return PEAR::isError($value); } I have set it to return FALSE at the minute as I am not too sure what to do (perhaps check for PEAR existence and if not check for parent isError() existence). Anyway, you can't get it to work if you don't have PEAR installed and even if so this function doesn't make sense.

Some class comments should be corrected as well, as sometimes it only refers to PEAR.

ccazette avatar Apr 29 '10 06:04 ccazette

I can confirm this is a problem for me after trying to extend the DatabaseConnection class. Took me some time to debug to locate the problem, finally narrowed it down to this line.

brianwozeniak avatar Jul 25 '13 20:07 brianwozeniak

This repo is being archived. Closing issue.

timcappalli avatar Jul 24 '23 18:07 timcappalli