OpenID4VP icon indicating copy to clipboard operation
OpenID4VP copied to clipboard

Update Appendix 1 to be consistent with the latest snapshot of the Digital Credentials API

Open samuelgoto opened this issue 1 year ago • 5 comments

There are at least 2 PRs (this and this) that were merged (or are under review) after Appendix 1 was written and merged, making the current snapshot out of date.

We know that time is of the essence here, so @marcoscaceres and I are trying to get all known breaking changes merged before TPAC ends next week.

Would it be possible to update Appendix 1 once those changes get merged?

I'm only aware of this and this, and we are trying to avoid backwards incompatible changes as much as we possibly can, but wanted to get a sense of what process we should follow and align our expectations on timelines, hence asking here.

samuelgoto avatar Sep 16 '24 21:09 samuelgoto

Note that on the W3C side, we reserve the right to change whatever we want... this is an incubation after all. As @samuelgoto notes, we are being careful not to make backwards incompatible changes. At the same time, the WICG spec has no official standing and it's literally an "incubation" (as it states in the Status section: "This is an unofficial proposal.").

We warn in the README that:

🚧 Note: The API is still extremely unstable and undergoing a lot of changes (almost daily!). 🚧

(We should add that to the spec too)

And, as is stated in all W3C specifications during working draft phase:

This is a draft document and may be updated, replaced or obsoleted by other documents at any time. It is inappropriate to cite this document as other than work in progress.

marcoscaceres avatar Sep 16 '24 21:09 marcoscaceres

Noting the difficulties and disclaimers of working across SDOs with disparate timelines, it would be good to be as consistent as the given situation allows. I've had a mental todo to chase that down once those get merged. But I forget stuff. So thanks @samuelgoto for making it explicit.

Would it be possible to update Appendix 1 once those changes get merged?

I believe so, yes. Feel free to put in a PR. Or nudge me to do it.

bc-pi avatar Sep 16 '24 22:09 bc-pi

https://github.com/WICG/digital-credentials/pull/164 has been merged

bc-pi avatar Sep 18 '24 20:09 bc-pi

https://github.com/WICG/digital-credentials/pull/165 has also been merged

bc-pi avatar Sep 19 '24 21:09 bc-pi

and https://github.com/WICG/digital-credentials/issues/170 "Update example to show feature detection" seems potentially relevant

bc-pi avatar Sep 19 '24 21:09 bc-pi

has this been resolved with https://github.com/openid/OpenID4VP/pull/254 ? closing in a week unless objections.

Sakurann avatar Dec 05 '24 01:12 Sakurann