OpenID4VP icon indicating copy to clipboard operation
OpenID4VP copied to clipboard

PE Schema Validation Problems

Open OIDF-automation opened this issue 3 years ago • 4 comments

Imported from AB/Connect bitbucket: https://bitbucket.org/openid/connect/issues/1439

Original Reporter: @David-Chadwick

Currently some non-trivial examples of presentation definitions from the DIF PE specification are causing OIDC schema validation to fail. One example is if a VC contains a set of values, and the PD tries to choose one of the set by using “oneOf” or “anyOf”. This issue has been raised in the DIF PE group (see https://github.com/decentralized-identity/presentation-exchange/issues/280 and https://github.com/decentralized-identity/presentation-exchange/issues/303 )

DIF say they are using the JSON schema defined in https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02 which allows more complex constructs such “oneOf” and “anyOf”.

The current workaround for OIDC has been to use simpler examples in the OIDC specifications.

This issue is a placeholder to ensure that any problems with schema validation are resolved before the final specification is published

OIDF-automation avatar Feb 19 '22 11:02 OIDF-automation

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

David, could you please give us an update on this item? PE went to v2, but in the PE repo, issue 303 was closed, but issue 280 is still open. Has this been resolved or not?

OIDF-automation avatar Aug 24 '22 22:08 OIDF-automation

Imported from AB/Connect bitbucket - Original Commenter: dwc8

As I recall, 303 was closed because it was not deemed to be a bug in PE, but rather in the schema validation tool that was being used (i.e. the tool was not sufficiently enhanced to support oneOf or anyOf.

280 has not been closed because there is an outstanding request on Torsten to provide an erroneous example.

OIDF-automation avatar Aug 25 '22 14:08 OIDF-automation

Imported from AB/Connect bitbucket - Original Commenter: mbj

Note this is a placeholder reminding us of issues in the PE spec.

OIDF-automation avatar Mar 20 '23 23:03 OIDF-automation

(Issue in the PE spec has been closed, but i don't think this issue is resolved?)

Sakurann avatar Apr 03 '24 20:04 Sakurann

The solution here is to specify a version of JSON Schema to use. The PE spec today references Draft 7 so it may be simplest to enshrine that in the v2.X spec. I will recommend that to the DIF group.

decentralgabe avatar Jun 19 '24 03:06 decentralgabe

I have opened https://github.com/decentralized-identity/presentation-exchange/issues/480

decentralgabe avatar Jun 20 '24 03:06 decentralgabe

https://github.com/decentralized-identity/presentation-exchange/pull/481

decentralgabe avatar Jun 26 '24 03:06 decentralgabe

this should be addressed by specifying Draft 7 here https://github.com/decentralized-identity/presentation-exchange/pull/481

closing this now, please re-open if this solution is insufficient.

there may be work in the OID4VP spec to specify JSON Schema Draft 7.

decentralgabe avatar Jun 26 '24 23:06 decentralgabe