OpenID4VCI icon indicating copy to clipboard operation
OpenID4VCI copied to clipboard

Unreferenced examples

Open c2bo opened this issue 1 year ago • 2 comments

As discussed in last DCP call, there are some examples in the examples folder of this repository that are currently not referenced in the spec.

This is the list of currently not referenced examples I found:

  • credential_request_jwt_vc_json-ld.json
  • credential_request_iso_mdl.json
  • credential_offer_pre-authz_code.json
  • credential_offer_sd_jwt_vc.json
  • credential_request_jwt_vc_json.json

Should I create a PR removing these or are there some of these we want to reference in the spec / want them to stay in the repo?

c2bo avatar Jan 29 '24 12:01 c2bo

I took a look at each of the examples. I am ok deleting these:

  • credential_request_iso_mdl.json - there is another file with the name one _with_claims which is used in the spec and is more detailed
  • credential_offer_sd_jwt_vc.json - ok deleting because this is credential format specific and we have already deleted other credential format specific CO files
  • credential_request_jwt_vc_json.json - there is another file with the name one _with_claims which is used in the spec and is more detailed

I would like to keep the following:

  • credential_offer_pre-authz_code.json - this is not credential format specific and is useful.
  • credential_request_jwt_vc_json-ld.json - these is no equivalent of this

did a PR with this for now...

Sakurann avatar Jan 30 '24 20:01 Sakurann

I would like to keep the following:

  • credential_offer_pre-authz_code.json - this is not credential format specific and is useful.
  • credential_request_jwt_vc_json-ld.json - these is no equivalent of this

did a PR with this for now...

If we are keeping these because they're useful, can/should we add references to them in the specification?

jogu avatar Jan 31 '24 14:01 jogu