AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard

Remove platforms declaration to avoid deployment target warnings

Open CemYil03 opened this issue 3 years ago • 13 comments

This is required to fix the following warning in Xcode 13.1: "The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.0.99."

CemYil03 avatar Nov 19 '21 09:11 CemYil03

@CemYil03 since the deployment target specified is actually the base required for Swift Package Manager, I'd suggest removing the platforms declaration entirely. This will remove the build warning that appears in lower versions of Xcode too.

I recommend taking a look at these two links if you want further information: https://forums.swift.org/t/xcode12-minimum-deployment-target-and-spm/40467 https://github.com/nanopb/nanopb/pull/585/files

Oliver-Binns avatar Nov 23 '21 22:11 Oliver-Binns

I would second @Oliver-Binns comment. Would be great if you could apply the change by removing the platforms definition altogether.

simonseyer avatar Dec 02 '21 13:12 simonseyer

First I thought this could result in compile errors, but it seems to work. The change is now in the latest commit

CemYil03 avatar Dec 02 '21 15:12 CemYil03

Would really like to merge it in asap. Any idea who to contact?

CemYil03 avatar Dec 22 '21 23:12 CemYil03

@WilliamDenniss looks like you've merged a few recently? 🙂 please can you take a look here?

Oliver-Binns avatar Dec 23 '21 16:12 Oliver-Binns

Someone like @WilliamDenniss or @julienbodet do you have the rights to perform a merge?

CemYil03 avatar Jan 03 '22 00:01 CemYil03

@marcoceppi @iainmcgin @panva Sorry to bother you, but can anyone from openid review and merge this pull request?

khalideali avatar Jan 11 '22 23:01 khalideali

I unfortunately can only review the PHP OpenID project. Asking here may help: http://lists.openid.net/mailman/listinfo/openid-code

marcoceppi avatar Jan 11 '22 23:01 marcoceppi

Please, could anyone merge this MR ? 🙏🏻

julien-baillon avatar Feb 16 '22 16:02 julien-baillon

@petea Is this something you can help review and merge?

marcoceppi avatar Feb 16 '22 18:02 marcoceppi

This has been addressed with #690

petea avatar Apr 07 '22 15:04 petea

@petea did you see Oliver-Binns's https://github.com/openid/AppAuth-iOS/pull/661#issuecomment-977207559? Surely, #690 is better than nothing, but it'll only work until it'll break soon.

nh7a avatar Apr 14 '22 21:04 nh7a

@nh7a I did, and will consider taking that step next.

petea avatar Apr 14 '22 22:04 petea