AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard

Add emphemeral browser option iOS/Catalyst user agents.

Open danblakemore opened this issue 4 years ago • 1 comments

Adds BOOL properties to iOS/Catalyst-related methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.

danblakemore avatar Jun 23 '21 22:06 danblakemore

This would be really useful to have so we don't have to set up a custom user agent. What's the process of getting a PR like this merged?

sgrgrsn avatar Nov 10 '21 14:11 sgrgrsn

@danblakemore since you sent this PR, we've added ASWebAuthenticationSession support to OIDExternalUserAgentMac with #675. For consistency, would you be willing to extend your approach here to this macOS implementation of OIDExternalUserAgent as well? Implementation should be very similar to the iOS case.

petea avatar Aug 16 '22 19:08 petea

Yep, I can send a new one shortly.

danblakemore avatar Aug 16 '22 22:08 danblakemore

Is there any timeline for this PR to be merged?

amritnew avatar Aug 17 '22 13:08 amritnew

Let me know if there's additional changes required for this PR.

danblakemore avatar Aug 17 '22 15:08 danblakemore

Dear Team, Thanks a lot for solving the logout issue. With this prefersEphemeralSession parameter for external user-agents we are able to do a proper logout of our users in our IOS application. We need to release our app in September. @danblakemore when can we expect the next release of AppAuth pod with this change?

Tijijoy1989 avatar Aug 19 '22 11:08 Tijijoy1989

@petea any timeline for the next release?

diegoventura avatar Aug 30 '22 08:08 diegoventura

Hoping to have 1.6.0 out sometime next week.

petea avatar Aug 30 '22 21:08 petea