AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard

Published 20 hours ago • verified publisher icon openid

macOS: Improve HTML page when authorization completes in the browser

Open roop opened this issue 3 years ago • 2 comments

When using AppAuth in macOS, AppAuth creates a local webserver in the app so that the authorization flow can use the default browser. Once the authorization flow completes, the page shown on the tab used for authorization is currently a very bare HTML page with no styling at all. This PR adds some basic styling that makes the page look better. The same HTML template is used in case authorization succeeded or failed.

roop avatar Apr 29 '21 08:04 roop

The "swift test" failure in travis-ci seems to be unrelated to this change -- it still fails without these changes.

roop avatar Apr 30 '21 07:04 roop

I like the idea of a nicer HTML page. However, I would prefer to provide the strings by accessors instead of statics. This way you cloud subclass OIDRedirectHTTPHandler and show your own localised strings to the enduser.

stefanfuerst avatar Mar 22 '22 10:03 stefanfuerst