AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard

Change iOS deployment target for Xcode 12

Open davbeck opened this issue 4 years ago • 9 comments

This removes the warning about iOS 8 no longer being supported in Xcode 12 while maintaining support for older versions of Xcode. Technically checking the compiler version isn’t an exact 1:1 for checking for Xcode version, but in practice should work in all scenarios.

davbeck avatar Nov 30 '20 21:11 davbeck

@davbeck Could we get this merged? Would a great help to not have Xcode complain about deployment target when using the SPM module

JackoPlane avatar Jan 15 '21 02:01 JackoPlane

@julienbodet Any chance that this could get released as a patch? The warnings have been there for quite some time now 😬

ghost avatar Feb 18 '21 08:02 ghost

@WilliamDenniss Could we get this merged some time soon?

JackoPlane avatar Feb 24 '21 00:02 JackoPlane

Is there any update of whether this PR will be merged?

Our CI build processes continue to show these warnings when using this library

ChrisPearce avatar Apr 05 '21 03:04 ChrisPearce

+1 for a merge please, can't find any other way to remove these warnings. (SPM)

robinhayward avatar Apr 14 '21 11:04 robinhayward

Like to see it merged asap to get rid of warnings with SPM

moban-michael avatar Apr 14 '21 12:04 moban-michael

Please merge this

jakobmygind avatar Jul 06 '21 08:07 jakobmygind

Is also covered in #661. Can anyone contact the maintainers to merge one of those? These warnings are really annoying to me...

CemYil03 avatar Jan 03 '22 00:01 CemYil03

#661 is a better implementation of this. It would be preferable to merge that instead.

The platform declarations can be removed entirely as they match the minimum version supported by SPM: https://forums.swift.org/t/xcode12-minimum-deployment-target-and-spm/40467 https://github.com/nanopb/nanopb/pull/585/files

Oliver-Binns avatar Jan 05 '22 12:01 Oliver-Binns