AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard

Update parameter nullability

Open davedelong opened this issue 3 years ago • 5 comments

Fixes #565

davedelong avatar Jul 25 '20 18:07 davedelong

Codecov Report

Merging #566 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   72.77%   72.77%           
=======================================
  Files          33       33           
  Lines        2490     2490           
=======================================
  Hits         1812     1812           
  Misses        678      678           
Impacted Files Coverage Δ
Source/AppAuthCore/OIDEndSessionRequest.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7232d6e...e1d78da. Read the comment docs.

codecov-commenter avatar Jul 25 '20 18:07 codecov-commenter

Thanks davedelong, it would be great to see this merged!

markusfassbender avatar Nov 23 '20 22:11 markusfassbender

@davedelong could you update the nullability annotations for the initializer implementations as well?

@davedelong If you give me access to the branch for this pull request I could do this update. (I'd be glad to get this pull request merged too.)

philet avatar Apr 07 '22 15:04 philet

@petea @philet I'm not using this project anymore and am intending to delete my fork just to keep my personal GitHub tidy. You're welcome to copy the diff and re-apply it. All I did was add 5 nullability annotations.

davedelong avatar Apr 07 '22 15:04 davedelong

@davedelong @petea Ok. I created a new pull request for this issue: https://github.com/openid/AppAuth-iOS/pull/702

philet avatar Apr 08 '22 08:04 philet