AppAuth-iOS
AppAuth-iOS copied to clipboard
Update parameter nullability
Fixes #565
Codecov Report
Merging #566 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 33 33
Lines 2490 2490
=======================================
Hits 1812 1812
Misses 678 678
Impacted Files | Coverage Δ | |
---|---|---|
Source/AppAuthCore/OIDEndSessionRequest.h | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7232d6e...e1d78da. Read the comment docs.
Thanks davedelong, it would be great to see this merged!
@davedelong could you update the nullability annotations for the initializer implementations as well?
@davedelong If you give me access to the branch for this pull request I could do this update. (I'd be glad to get this pull request merged too.)
@petea @philet I'm not using this project anymore and am intending to delete my fork just to keep my personal GitHub tidy. You're welcome to copy the diff and re-apply it. All I did was add 5 nullability annotations.
@davedelong @petea Ok. I created a new pull request for this issue: https://github.com/openid/AppAuth-iOS/pull/702