fix nullability warning in OIDExternalUserAgentIOS

[markusfassbender]

Closes #442

It has been wrong to declare the initializers as nullable, because it conflicted with the implementation of NSObject. Please see the description in #442.

From the NSObject documentation:

In terms of nullability, callers can assume that the NSObject implementation of init() does not return nil.

[codecov-io]

Codecov Report

Merging #488 into master will not change coverage. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          63       63           
  Lines        5412     5412           
=======================================
  Hits         3904     3904           
  Misses       1508     1508

Impacted Files	Coverage Δ
Source/iOS/OIDExternalUserAgentIOS.m	0% <0%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e0b5c1...0aed29d. Read the comment docs.

[ChristianSteffens]

Ping

[markusfassbender]

I've singed all documents, please merge this PR if there are no discussions left. thanks!

[bpollman]

Any reason this isn't getting merged? Would love get this update.

[markusfassbender]

Bump

[amg1976]

It would be great to see this PR merged

[clemens-schulz]

Please merge this. 🙂

[mpashnyov]

@WilliamDenniss Any reason this isn't getting merged?

[codecov-commenter]

Codecov Report

Merging #488 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files          50       50           
  Lines        4617     4617           
=======================================
  Hits         3867     3867           
  Misses        750      750           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df840e8...ef464e9. Read the comment docs.

[markusfassbender]

I've updated my branch to the master head. Please merge this little fix, thanks!

[KostyaKulakov]

Will it be merged?

[KostyaKulakov]

@WilliamDenniss

[DrewKiino]

can we merge this pleeeeeeeeeeeeaaaaaaaaaasee.

[HashimPhilips]

HI team , is there any reason this is still not merged. it is really sad that the issue is still there even after solution exists

[davidevincenzi]

Ping @WilliamDenniss 🙏

[ChrisPearce]

Is there any update of whether this PR will be merged?

Our CI build processes continue to show nullability warnings when using this library.

[james919]

can we merge this pleeeeeeeeeeeeaaaaaaaaaasee.

[markusfassbender]

Thank you @petea

[petea]

@dermaaarkus have you signed the contributor agreements?

[0xced]

I have signed the contributor agreement on #502 (which is a superset of this pull request).

Let's hope we'll finally see this fixed 🤞.

[markusfassbender]

Yes I've signed it a few years ago, but didn't find it in my mails quickly

[markusfassbender]

@petea I've signed the CLA again and send it to [email protected], as it was linked in the CONTRIBUTION guide. Thanks!

[markusfassbender]

Hello?

[petea]

@dermaaarkus sorry for the delay, I'm trying to track down your contributor agreement documents. Just confirming that you signed and submitted both documents as outlined here?

[markusfassbender]

Thanks @petea, i didn't see the second document. It's ridiculous in my opinion to do all that for a simple change. But I filled everything out and hope it will be merged soon. Thanks!

[markusfassbender]

My request got rejected due to some mistakes. Sorry I close this PR I don't want to invest here anymore.