AppAuth-JS icon indicating copy to clipboard operation
AppAuth-JS copied to clipboard

Published 20 hours ago • verified publisher icon openid

Fixes various issues in authorization request handlers

Open pixtron opened this issue 5 years ago • 7 comments

  • Improves error handling #94
  • Catches NodeBasedHandler server startup error (eg: EADDRINUSE) #95
  • NodeBasedHandler only opens authorization url if server could be successfully started, to avoid leaking Tokens to another process listening on the configured port.
  • Server in NodeBasedHandler now only binds to loopback (127.0.0.1) interface #93

pixtron avatar Dec 06 '19 23:12 pixtron

@tikurahul could you check the PR again after my changes regarding your comments?

pixtron avatar Dec 14 '19 23:12 pixtron

@tikurahul We are interested in having this PR releases as it addresses our security concerns.

huangyq23 avatar Jan 16 '20 00:01 huangyq23

@tikurahul please let me know if there is something holding you back merging this PR.

pixtron avatar Jan 21 '20 00:01 pixtron

@tikurahul Sorry, thank you for seeing this PR.

NaokiOtsu avatar Feb 03 '20 03:02 NaokiOtsu

Hi, do you still consider to merge this pull request as we are pretty interested in those changes?

chrissy25 avatar Jun 17 '20 10:06 chrissy25

+1

jmakr0 avatar Jul 01 '20 14:07 jmakr0

any reason why this hasn't been merged?

DSchrupert avatar Dec 28 '20 02:12 DSchrupert