AppAuth-Android icon indicating copy to clipboard operation
AppAuth-Android copied to clipboard

Any pro-guard file for this lib ?

Open SDemonUA opened this issue 7 years ago • 5 comments

Seems like pro-guard removes classes responsible for proccessing redirects to redirect_uri and thus app fails.

Is there some configuration special for this lib instead of: -keep class net.openid.**

SDemonUA avatar Sep 14 '18 14:09 SDemonUA

We don't currently maintain a ProGuard file for the library; it was my understanding that activities that are referenced from your app's manifest, and code that they depend upon, would be retained. That should be sufficient to retain the necessary activities for AppAuth. However, if this isn't the case, we'll accept this as a feature request and add a ProGuard configuration to the library. Contributions to help with that would be greatly appreciated.

iainmcgin avatar Sep 18 '18 20:09 iainmcgin

Well my app is as simple as it can be. I use "performAuthorizationRequest" to authorize user, after user submit his credentials in browser and get redirected to redirectURI app crashes with error

Unable to instantiate activity ComponentInfo{com.unet.inviter/net.openid.appauth.RedirectUriReceiverActivity}: java.lang.ClassNotFoundException: Didn't find class "net.openid.appauth.RedirectUriReceiverActivity"

SDemonUA avatar Sep 19 '18 10:09 SDemonUA

Actually -keep class net.openid.appauth.RedirectUriReceiverActivity is enogth for my situation, but I'm not sure if it will work for every usecases.

SDemonUA avatar Sep 19 '18 10:09 SDemonUA

@iainmcgin We are facing a crash specific to the Samsung internet browser when minifyEnabled true. Tried with all possibilities of proguard rules, still facing crash once credentials are submitted.

Sanjay-Katagihallimath avatar Oct 20 '21 15:10 Sanjay-Katagihallimath

@Sanjay-Katagihallimath do you mind providing the actual crash?

agologan avatar Oct 24 '21 08:10 agologan