ohpc
ohpc copied to clipboard
openhpc
Use a .patch to comment out Slurm settings which need to be overwritten by OpenHPC
Test Results
11 files + 7 11 suites +7 0s :stopwatch: ±0s 32 tests +15 32 :white_check_mark: +15 0 :zzz: ±0 0 :x: ±0 33 runs +15 33 :white_check_mark: +15 0 :zzz: ±0 0 :x: ±0
Results for commit b7fd1f54. ± Comparison against base commit 46181bd5.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
How do you feel about having the changes from all the echo lines also be included in the patch?
It will work! I just wonder how often we will need to adapt the patch when upgrading Slurm. Looking at the Git history of https://github.com/SchedMD/slurm/commits/master/etc/slurm.conf.example I see that they make 1 or 2 changes per year. But most of the changes are in settings' values, not adding/removing settings (and thus change the line numbers). So probably it should be OK!
Right, having a patch is more work if upstream changes things. On the other hand it is probably more reliable to actually change the file as desired. grep, sed, echo will probably not give us feedback if something failed.