ohpc icon indicating copy to clipboard operation
ohpc copied to clipboard

ci: Support for building docs-ohpc.rpm at simple CI

Open martin-g opened this issue 2 years ago • 6 comments

Create dosc-ohpc.tar on the fly. Clones the complete Git repo to be able to run git describe later in the Makefile`s

martin-g avatar Sep 27 '23 13:09 martin-g

Successful CI results could be seen in my fork: https://github.com/martin-g/openeuler-ohpc/actions/runs/6326193045 I modified temporarily the docs.spec to trigger the build there.

martin-g avatar Sep 27 '23 13:09 martin-g

Good idea, but it should trigger on any Tex file changed in the repository. The script looks a bit hacky copying the whole .git history of another checkout into the PR.

adrianreber avatar Sep 27 '23 13:09 adrianreber

The script looks a bit hacky copying the whole .git history of another checkout into the PR.

Yep! Without this hack this error is thrown: https://github.com/openhpc/ohpc/blob/3.x/docs/recipes/install/almalinux9/aarch64/warewulf/slurm/Makefile#L12

Another solution is to fetch the whole history with actions/checkout action, but then the toll is that it will be done for all PRs. The current solution fetches the whole history only when docs.spec is changed.

martin-g avatar Sep 27 '23 13:09 martin-g

it should trigger on any Tex file changed in the repository

I'd say for anything in docs/ folder. I will see how to do it!

martin-g avatar Sep 27 '23 13:09 martin-g

@adrianreber Please review again! Changing a .tex file (without docs.spec) works! I just checked the uploaded rpm for openEuler. The Warewulf+OpenPBS manual contains

TESTING PR 1878
THIS IS A TEMPORARY CHANGE TO TEST THE BUILD OF DOCS WHEN A .TEX FILE IS MODI-
FIED

I will revert the last commit once you confirm!

martin-g avatar Sep 27 '23 14:09 martin-g

Test Results

 4 files  ±0   4 suites  ±0   0s :stopwatch: ±0s 17 tests ±0  17 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  18 runs  ±0  18 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 9f4b3c95. ± Comparison against base commit 19f35906.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 05 '23 08:10 github-actions[bot]

@martin-g If you want, let's get this ready.

adrianreber avatar Feb 29 '24 08:02 adrianreber

@adrianreber PTAL!

martin-g avatar Feb 29 '24 10:02 martin-g

Please rebase the latex error should be fixed.

adrianreber avatar Feb 29 '24 13:02 adrianreber