ohpc icon indicating copy to clipboard operation
ohpc copied to clipboard

Add hpc-workspace to OpenHPC

Open georgiastuart opened this issue 2 years ago • 3 comments

This is an attempt to fulfill #1403

hpc-workspace is an admin tool for managing directories with associated expiration dates and share groups.

This PR adds:

  • hpc-workspace spec file
  • hpc-workspace license
  • hpc-workspace config template

Open questions:

  • Is the admin category the correct spot for this component?
  • I included the default daily cleanup script, should that be changed?

georgiastuart avatar Aug 05 '22 18:08 georgiastuart

Please have a look at the result of the CI run on Leap. There seems to be an error.

adrianreber avatar Aug 05 '22 18:08 adrianreber

This is an attempt to fulfill #1403

Thanks!

Open questions:

  • Is the admin category the correct spot for this component?

Sounds good to me.

  • I included the default daily cleanup script, should that be changed?

That is indeed a difficult question. On the one hand I think this is the correct solution, on the other hand it could be a site specific setup. I would leave it as it is. Make sure it is mentioned in the documentation. Also maybe the cron setup should be marked as a config file so that RPM does not overwrite local changes on upgrade.

adrianreber avatar Aug 05 '22 19:08 adrianreber

Open tasks:

  • [ ] Mark cron job as config in spec
  • [ ] Add hpc-workspace-ohpc to documentation files
  • [x] Resolve UID/GID numbering

georgiastuart avatar Aug 05 '22 20:08 georgiastuart

Hey @georgiastuart,

For the cron job, we've decided not to include it as part of the RPM. We will document what needs to be done in the recipes and let sysadmins decide when to run it themselves based on their local usage patterns.

For the UID/GID numbering, you can go ahead and remove the specific group choice (85) and we will let the order of operations decide the UID/GID numbering as we do for SLURM/PBS and Munge.

I'll go ahead and do the documentation as well. If you'd like to make the above changes, and resubmit great. If you don't have the time, let me know and I'll do it.

Thanks again for your contribution!

mghpcsim avatar Nov 03 '22 18:11 mghpcsim

@mghpcsim Ready for the next review.

  • uid/gid is now 203 in spec and config template per our discussion
  • cron job removed

georgiastuart avatar Nov 07 '22 11:11 georgiastuart

Investigating the test failure.

georgiastuart avatar Nov 07 '22 11:11 georgiastuart