website icon indicating copy to clipboard operation
website copied to clipboard

"Download openHAB 4.0.0 SNAPSHOT Add-ons" suggests wrong name

Open spacemanspiff2007 opened this issue 2 years ago • 6 comments

Under download select the following

grafik

Then click on

grafik

Filename has the wrong extension "mid" instead of "kar"

grafik

spacemanspiff2007 avatar May 22 '23 03:05 spacemanspiff2007

Are you sure that your browser isn't doing any fancy stuff?

When I click this button, it is correctly downloading the kar (with this name):

Bildschirmfoto 2023-05-22 um 18 25 45

kaikreuzer avatar May 22 '23 16:05 kaikreuzer

The link shows the same for me but in the dialog it changes to .mid.

grafik

Are you sure that your browser isn't doing any fancy stuff?

That's absolutely possible. I am using the latest Firefox on Win10. I do download the snapshots quite often and every time I manually edit the suffix in the dialog yet it pops up again with .mid.

Would it be possible to use the download attribute for the link? That way the filename could be explicitly passed to the browser.

If not and if I am the only one who is having this behavior this issue can be closed.

spacemanspiff2007 avatar May 23 '23 03:05 spacemanspiff2007

I have created https://github.com/openhab/website/pull/407 for it. You can test on https://deploy-preview-407--openhab.netlify.app/download/ whether this resolves the issue for you.

kaikreuzer avatar May 25 '23 07:05 kaikreuzer

grafik

After the download there has to be a "=" with the filename - I've left a comment.

spacemanspiff2007 avatar May 25 '23 07:05 spacemanspiff2007

I will take care of the naming part, when #407 has been merged.

Confectrician avatar Jun 02 '23 08:06 Confectrician

@Confectrician Thanks a lot - go for it!

kaikreuzer avatar Jun 02 '23 11:06 kaikreuzer