org.openhab.binding.zwave icon indicating copy to clipboard operation
org.openhab.binding.zwave copied to clipboard

Problem with secure random generation of network key

Open cdjackson opened this issue 7 years ago • 8 comments

@dbadia we are seeing a number of problems with the new secure random number generation - it seems to be causing machines to lock up on initialisation. There have been a few instances of this - I've referenced the first below, but I've seen another one or two such problems, and we will soon have the 2.4 release version, and I'm worried that this will cause a big problem then.

Please can you investigate this otherwise I think we need to revert this change before 2.4 is released (in early December).

https://community.openhab.org/t/solved-zwave-binding-not-working-since-openhab2-2-4-0-snapshot/56988/12

cdjackson avatar Nov 24 '18 12:11 cdjackson

I can't reproduce the timeout here, so I am going to post a manual build to the original thread to see if someone there can test the fix. Will submit the PR after that

dbadia avatar Nov 26 '18 23:11 dbadia

@dbadia can I suggest that we should revert the secure random change for now Dave? Time is running out and I don't want to have this bug in the 2.4 release as we'll have to live with it for the next 6 months.

cdjackson avatar Dec 02 '18 16:12 cdjackson

Agreed @Chris. Do you want me to submit a PR to back it out?

On Sun, Dec 2, 2018, 11:56 AM Chris Jackson <[email protected] wrote:

@dbadia https://github.com/dbadia can I suggest that we should revert the secure random change for now Dave? Time is running out and I don't want to have this bug in the 2.4 release as we'll have to live with it for the next 6 months.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zwave/issues/1075#issuecomment-443522555, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgHp5IfxGCpUjfXznRpLhf-1qNKFeqwks5u1AYzgaJpZM4YxZT8 .

dbadia avatar Dec 02 '18 18:12 dbadia

Let's see if I can just revert https://github.com/openhab/org.openhab.binding.zwave/pull/1032

cdjackson avatar Dec 02 '18 18:12 cdjackson

Ok, that didn't work. Yes, if you can provide a PR that would be appreciated. I'm happy to add it back again after 2.4 is released (a couple of weeks) and we can work out what is happening.

cdjackson avatar Dec 02 '18 18:12 cdjackson

Sure, submitted #1079

On Sun, Dec 2, 2018 at 1:11 PM Chris Jackson [email protected] wrote:

Ok, that didn't work. Yes, if you can provide a PR that would be appreciated. I'm happy to add it back again after 2.4 is released (a couple of weeks) and we can work out what is happening.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zwave/issues/1075#issuecomment-443529144, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgHp6Db-NIcamst6a5fTEouE66MU4GZks5u1BftgaJpZM4YxZT8 .

dbadia avatar Dec 03 '18 01:12 dbadia

Should this be closed?

mhilbush avatar Jul 05 '19 14:07 mhilbush

Yes, it should be

dbadia avatar Jul 11 '19 01:07 dbadia