openhab-webui icon indicating copy to clipboard operation
openhab-webui copied to clipboard

New Crowdin updates

Open openhab-bot opened this issue 2 years ago • 2 comments

openhab-bot avatar Jun 23 '22 21:06 openhab-bot

Seems we still have a problem with translations being still linked to paths in the master branch and those in the main branch were duplicated but the translations didn't carry over. No idea how to solve this.

image

ghys avatar Jun 23 '22 21:06 ghys

If you want to fully replace main with master... it seems possible to rename branches in this view:

Screenshot from 2022-06-24 13-08-14

You may also need to change the name of the resulting file in "Settings".

If that does not work out well, you can also Download/Upload files on the home tab:

Screenshot from 2022-06-24 13-12-22

Then you can also run some script on the downloaded translations to fix it and upload them again.

It might be a good idea to download everything there anyhow in case something gets messed up. :wink:

wborn avatar Jun 24 '22 11:06 wborn

Would it be possible to fix the conflicts and commit the latest Crowdin translations before OH 3.4 is released @openhab/webui-maintainers ?

wborn avatar Dec 11 '22 08:12 wborn

Thanks for the suggestions above @wborn - I tried it but it appears the problem is even more shameful... The rename doesn't work because there's already a main root alongside the master root.

If we take a look at the activity at Crowdin it could be that in certain cases the new file locations (e.g. main/bundles/org.openhab.ui.habpanel) meant the strings went back to untranslated when the branch was renamed, and people in many cases did all the work again. Hope not too much and apologies to everyone if that's the case.

According to https://crowdin.com/project/openhab-habpanel/activity-stream the first mass upload (when HABPanel was moved from its own repo to this repo and the main branch was still called master) was on Dec 08, 2020.

openhab-bot uploaded 10,953 translations into Romanian, French, Spanish, Afrikaans, Arabic, Bulgarian, Catalan, Czech, Danish, German, Greek, Finnish, Hebrew, Hungarian, Italian, Japanese, Korean, Lithuanian, Dutch, Norwegian, Polish, Russian, Swedish, Turkish, Ukrainian, Chinese Simplified, Portuguese, Brazilian, Indonesian and Tagalog

Then on Jan 20, 2021 there was another one, this time for the main branch:

openhab-bot uploaded 10,953 translations into Romanian, French, Spanish, Afrikaans, Arabic, Bulgarian, Catalan, Czech, Danish, German, Greek, Finnish, Hebrew, Hungarian, Italian, Japanese, Korean, Lithuanian, Dutch, Norwegian, Polish, Russian, Swedish, Turkish, Ukrainian, Chinese Simplified, Portuguese, Brazilian, Indonesian and Tagalog

Then there's been a mix of translation suggestions both in master & main since both versions (of the same files) were presented to users... It could be that there are two different translations of the same string, how to choose then? I would say the one already in main being more recent would likely be the best?

I have downloaded the entire project as CSV and will have to do some processing to see how many conflicts there are, then merge the 2 trees into one (main). then reupload the CSV. Afterwards we can then probably remove the master tree.

ghys avatar Dec 11 '22 11:12 ghys

Closing & deleting the branch to let Crowdin open a new PR.

ghys avatar Dec 11 '22 11:12 ghys