openhab-webui icon indicating copy to clipboard operation
openhab-webui copied to clipboard

make webui work with non-root context path (#1290)

Open altaroca opened this issue 3 years ago • 3 comments

See explanation in in the issue openhab/openhab-webui#1290

things to consider:

  • testing for this will be difficult as it changes some logic at the heart of the ui.
  • testing needed for different browsers, uis, mobile apps. I have only used the main ui in chrome.
  • rest oauth will not work at non-root url. disable using console> bundle:stop org.openhab.core.io.rest.auth
  • this does not fix all absolute urls in the uis. Apache2 reverse proxy as in openhab/openhab-core#150 can take care of many of those
  • in time it would probably be good to fix all urls

altaroca avatar Jan 30 '22 15:01 altaroca

Hi @altaroca, FYI: I started looking into this and thank's to your work I really think this is doable (wouldn't have thought so a short while ago)! I refined and simplified a few things regarding the UI and will continue trying to solve open issues.

hubsif avatar Feb 05 '22 12:02 hubsif

@altaroca - thanks for this effort! I have yet to test this properly, give me a few days, but it's looking good already. However please note the contributing rules regarding signing off of your commits: https://github.com/openhab/openhab-core/blob/main/CONTRIBUTING.md#sign-your-work If you add the requested sign-off line as a comment in this discussion (Signed-off-by: ...) I will merge the PR with this line included.

ghys avatar Feb 05 '22 14:02 ghys

Great! I am happy if you think this works. As for merging I leave it up to you @ghys if you want to merge it as is or wait for a more complete solution by @hubsif. In any case I sign over any copyright I may own on this PR to you. You don't have to mention me. Too much paperwork 😃

altaroca avatar Feb 05 '22 17:02 altaroca

Closing as this went stale.

florian-h05 avatar Feb 26 '24 15:02 florian-h05