openhab-ios icon indicating copy to clipboard operation
openhab-ios copied to clipboard

Xcode Build Tool Plug-ins

Open weakfl opened this issue 2 years ago • 5 comments

Use Xcode Build Tool Plug-ins for SwiftFormat and SwiftLint

weakfl avatar Oct 08 '22 08:10 weakfl

@timbms @digitaldan are you both on Xcode 14 yet?

I would like to integrate SwiftFormat and SwiftLint as Xcode Build Tool Plug-ins and that would require Xcode 14. This has a couple of benefits, like reduced build times.

For now I'd use my own plugin versions, until Apple fixes https://github.com/SwiftGen/SwiftGenPlugin/issues/2 (I've filed FB11432401 a while ago, but it's not resolved yet).

weakfl avatar Oct 08 '22 08:10 weakfl

@timbms @digitaldan are you both on Xcode 14 yet?

Yep.

Reduced build times sound awesome, its quite a time suck whatever xcode is currently doing to recompile, even with small changes. I'll give this a go today and let you know if i run into any issues, thanks!

digitaldan avatar Oct 08 '22 14:10 digitaldan

@timbms @digitaldan are you both on Xcode 14 yet?

Yes

I would like to integrate SwiftFormat and SwiftLint as Xcode Build Tool Plug-ins and that would require Xcode 14. This has a couple of benefits, like reduced build times.

Good idea swiftformat 0.50 also knows about swift 5.7 allowing for nice syntax shortcuts

For now I'd use my own plugin versions, until Apple fixes https://github.com/SwiftGen/SwiftGenPlugin/issues/2 (I've filed FB11432401 a while ago, but it's not resolved yet).

timbms avatar Oct 08 '22 14:10 timbms

Good idea swiftformat 0.50 also knows about swift 5.7 allowing for nice syntax shortcuts

@weakfl you were already a step ahead; I have seen it later that the PR already considers swift 5.7

timbms avatar Oct 08 '22 22:10 timbms

@timbms yes, I've set the swift version to 5.7 and the files should already be formatted accordingly.

weakfl avatar Oct 09 '22 06:10 weakfl

@timbms @digitaldan I think we can merge?

weakfl avatar Oct 20 '22 15:10 weakfl

Go ahead and merge👍🏽

timbms avatar Oct 23 '22 12:10 timbms