openhab-docs icon indicating copy to clipboard operation
openhab-docs copied to clipboard

[Sitemaps] Element Type ‘Chart’: begin/end wrong?

Open hreichert opened this issue 6 years ago • 4 comments

Page: http://docs.openhab.org/configuration/sitemaps.html#element-type-chart Source: https://github.com/openhab/openhab-docs/blob/gh-pages/configuration/sitemaps.md#element-type-chart

Regarding to this:

Chart [item=] [icon=""] [label=""] [refresh=xxxx] [period=xxxx] [service=""] [begin=yyyyMMddHHmm] [end=yyyyMMddHHmm]

and

begin / end represent the beginning and end of the time axis of the chart. Valid values are in the format: "yyyyMMddHHmm" (yyyy = year, MM = month, dd = day, HH = hour (0-23), mm = minutes).

I defined a Chart in in my sitemap: Chart item=gChart begin=201701010000 end=201801010000

Following error occurs:

[WARN ] [.e.s.m.c.i.ModelRepositoryImpl:92 ] - Configuration model 'demo.sitemap' has errors, therefore ignoring it: [8,27]: no viable alternative at input 'begin'

I looked at the model sources, Sitemap.xtext and found no references to begin/end:

Chart:
    'Chart' (('item=' item=ItemRef) & ('label=' label=(ID | STRING))? & ('icon=' icon=Icon)? &
    ('service=' service=(STRING))? & ('refresh=' refresh=INT)? & ('period=' period=ID) &
    ('labelcolor=[' (LabelColor+=ColorArray (',' LabelColor+=ColorArray)* ']'))? &
    ('valuecolor=[' (ValueColor+=ColorArray (',' ValueColor+=ColorArray)* ']'))? &
    ('visibility=[' (Visibility+=VisibilityRule (',' Visibility+=VisibilityRule)* ']'))?);

I think the ChartProvider does support the begin/end attributes, because this works as expected: http://localhost:8080/chart?groups=gChart&begin=201701010000&end=201801010000

My questions:

  • What is wrong? The documentation or the implementation?
  • If the implementation is wrong: Where should I open a ticket? Eclipse Smarthome?

hreichert avatar Sep 16 '17 23:09 hreichert

Anyone?

hreichert avatar Sep 27 '17 18:09 hreichert

@hreichert maybe you have more luck discussing this in the forum first? Can't help you here personally as I never used this feature, but I would think that the forum may be the better place to start this discussion and get more guidance/input

LightIsLife avatar Sep 27 '17 18:09 LightIsLife

@LightIsLife Thanks for your reply. I don't want to use this feature either, but I discovered that there is something wrong here while working on other chart related stuff. As I think that just the documentation is wrong, I opened the issue here.

hreichert avatar Sep 27 '17 18:09 hreichert

Hello @hreichert, at first read I also wasn't sure about the right answer. Your decision to open an issue here was right. Now I think before removing the feature from docs it would be worth reporting the issue at eclipse/smarthome.

ThomDietrich avatar Sep 27 '17 20:09 ThomDietrich