openhab-core icon indicating copy to clipboard operation
openhab-core copied to clipboard

Binding ID in JarFileAddonService vs. KarafAddonService

Open nils opened this issue 1 year ago • 3 comments

I have received a bug report in the PJLinkDevice binding, and I'm sure that the bug was not there in 2.5.x when the binding was introduced.

I suspect the way the core/ui handles binding IDs has changed. The interesting bit is that the functionality works perfectly fine when installed from a JAR, but it does not work when installed from the openhab distribution.

I have explained my observations here and raised some questions on how I should proceed with the bug.

Could one of @openhab/core-maintainers please comment?

nils avatar Mar 09 '24 10:03 nils

IMO add-on id and feature name should always be lower-case and never use camel-case. Is there any other example of that?

J-N-K avatar Mar 09 '24 15:03 J-N-K

should always be lower-case and never use camel-case.

I hope somebody else will comment and that's not a question for me, because that's exactly the clarification I'm looking for... If they should never be CamelCase I'd be interested if there is any chance to get the pjlink binding adapted without a breaking change.

The issue is only noticable for those users who want to use the UI to add things, the binding is working fine for everybody else. Forcing all the users with existing things through a breaking change is something I'd like to avoid if possible.

nils avatar Mar 14 '24 12:03 nils

We can rewrite the installed add-ons (see https://github.com/openhab/openhab-distro/pull/1530), so only those that configure add-ons in addons.cfg will need to adjust it there. I don't think that there will be anything else to adjust for users.

J-N-K avatar May 02 '24 14:05 J-N-K

I think this has been answered.

J-N-K avatar Jun 05 '24 19:06 J-N-K