openhab-core icon indicating copy to clipboard operation
openhab-core copied to clipboard

Published 20 hours ago • verified publisher icon openhab

Introduce metadata for all add-ons

Open J-N-K opened this issue 3 years ago • 3 comments

Closes #2058 Depends on #2994

  • [x] Adjust add-ons in openhab-addons (https://github.com/openhab/openhab-addons/pull/13289)
  • [x] Adjust zwave binding (https://github.com/openhab/org.openhab.binding.zwave/pull/1798)
  • [ ] Adjust zigbee binding
  • [x] Adjust add-ons on openhab-webui (https://github.com/openhab/openhab-webui/pull/1468)
  • [x] Adjust Developer documentation (https://github.com/openhab/openhab-docs/pull/1872)
  • [x] Adjust add-on template

This removes the binding.xml and replaces it with an addon.xml which allows to provide metadata for all add-ons. Also contains necessary changes in other components.

J-N-K avatar Jul 24 '22 19:07 J-N-K

I don’t see a PR for updating the developer documentation / binding template etc. Am I overlooking something? I hope so.

lsiepel avatar Aug 18 '22 17:08 lsiepel

The i18n-plugin also needs to be updated as it reads Binding XML info for generating translations. It will probably still compile locally because its bundle dependency still exists in your local and the OH snapshot repo.

wborn avatar Aug 19 '22 08:08 wborn

The i18n-maven-plugin changes are already part of this PR.

J-N-K avatar Aug 19 '22 16:08 J-N-K

What is the next step for this PR? Perhaps now would be a good time to get it finished so we have a full release cycle for testing, assuming it would make it into the first 4.0 milestone.

Before asking @J-N-K to resolve merge conflicts (also in related PR's) and preparing a PR for the Zigbee binding, perhaps a @openhab/core-maintainers could have a look and write some kind of statement about "conditional approval", so that Jan won't have to resolve conflicts and rebase too many times? @kaikreuzer - it seems this was suggested by you in #2058, so perhaps you could have a look and comment? 🙂

jlaur avatar Jan 01 '23 12:01 jlaur

Good point @jlaur! Yes, I'll have a look at it the next days (latest by the end of the week). Thanks @J-N-K for rebasing it already.

kaikreuzer avatar Jan 10 '23 21:01 kaikreuzer

Adjust zigbee binding

I assume it'll be pretty quick and straight forward to address this as well as soon as this PR here is merged, right?

kaikreuzer avatar Jan 14 '23 22:01 kaikreuzer

Yes, a second zwave and zigbee PR are easy, as I said in webui: for openhab-addons I need a short time.

J-N-K avatar Jan 14 '23 22:01 J-N-K

Could you please fix the project name in the 2 moved .project files? (I know, you are not using Eclipse, but for those who do this is important. 😄 )

kaikreuzer avatar Jan 14 '23 22:01 kaikreuzer

Done

J-N-K avatar Jan 14 '23 22:01 J-N-K

Thanks, I also prepared the missing PR for zwave and zigged (which are quite straight-forward) and updated the PR in openhab-addons (which is also mostly copying and addition of the new add-ons like persistence). What is missing is a proper review of the webui-PR regarding the changes in MainUI.

J-N-K avatar Jan 15 '23 11:01 J-N-K

I think it's fine now, I removed some leftovers in addons, otherwise I would say: Go! If something comes up I can fix it on short notice.

J-N-K avatar Jan 15 '23 13:01 J-N-K

Excellent, then let us go for it!

kaikreuzer avatar Jan 15 '23 14:01 kaikreuzer

@kaikreuzer Can you upload the XSD so it is available for validation? I'll prepare a PR to change the static analysis.

J-N-K avatar Jan 15 '23 18:01 J-N-K

It is all in git. :-) XSD uploaded here: https://github.com/openhab/website/pull/387

kaikreuzer avatar Jan 15 '23 22:01 kaikreuzer