openhab-addons icon indicating copy to clipboard operation
openhab-addons copied to clipboard

Published 20 hours ago • verified publisher icon openhab

[unifi] Provide LED channels for access point

Open jlaur opened this issue 4 months ago • 1 comments

Adds new channels for controlling LED on access point:

  • ledOverride: When OFF, the site-wide setting for device LED is used, otherwise channel ledColor is applied.
  • ledColor: This controls the color of the LED. Please note that some AP's might not support colors. The channel can be linked to a Switch item for simply turning the LED on or off.

TODO:

  • [x] README
  • [x] Update instructions
  • [x] I18N properties
  • [x] Channel ledColor should be advanced like ledOverride (or none of them should be)
  • [ ] Fully synchronize color/brightness/on-off (black = off, so when turning on, color should set to something not black)

This PR conflicts with #17530 and will need to be rebased after merging that.

JAR for testing: org.openhab.binding.unifi-4.3.0-SNAPSHOT.jar

Test report

Tests are performed with an access point only supporting blue color and not setable brightness. Each test has an initial state, a visual result and a verification of the persisted values for the device. Items:

  • Switch LED_Override linked to channel ledOverride
  • Color LED_Color linked to channel ledColor
  • Dimmer LED_Brightness linked to channel ledColor
  • Switch LED_Switch linked to channel ledColor
Testcase Status
Default → Override Passed
Override → Default Passed
Default: Brightness 100 → 50 Passed
Default: Brightness 50, Color Blue → Green Passed
Default: Brightness 100, Color Blue → Green Passed
Default, Brightness 50, Color Green → Override Passed
Override, Brightness 50, Color Green → Brightness 0 Passed
Override, Brightness 0, Color Green → Brightness 1 Passed
Override, Brightness 0, Color Green → ON Passed

  1. Default → Override Initial state:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

    Action:

    openhab:send LED_Override ON

    Result:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

  2. Override → Default Initial state:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

    Action:

    openhab:send LED_Override OFF

    Result:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

  3. Default: Brightness 100 → 50 Initial state:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

    Action:

    openhab:send LED_Brightness 50

    Result:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 50,

  4. Default: Brightness 50, Color Blue → Green Initial state:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 50,

    Action:

    openhab:send LED_Color 120.000,100,50

    Result:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#008000",
"led_override_color_brightness": 50,

    Comment: Was #008000, now fixed to to #00ff00 since brightness is separate.

  5. Default: Brightness 100, Color Blue → Green Initial state:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#0000ff",
"led_override_color_brightness": 100,

    Action:

    openhab:send LED_Color 120.000,100,100

    Result:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 240.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#00ff00",
"led_override_color_brightness": 100,

  6. Default, Brightness 50, Color Green → Override Initial state:

    • Visual: LED off
    • LED_Override: OFF
    • LED_Color: 120.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "default",
"led_override_color": "#00ff00",
"led_override_color_brightness": 50,

    Action:

    openhab:send LED_Override ON

    Result:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 120.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#00ff00",
"led_override_color_brightness": 50,

  7. Override, Brightness 50, Color Green → Brightness 0 Initial state:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 120.000,100,50
    • LED_Brightness: 50
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#00ff00",
"led_override_color_brightness": 50,

    Action:

    openhab:send LED_Brightness 0

    Result:

    • Visual: LED off
    • LED_Override: ON
    • LED_Color: 0,0,0
    • LED_Brightness: 0
    • LED_Switch: OFF
    "led_override": "off",
"led_override_color": "#00ff00",
"led_override_color_brightness": "0",

    Comment: Color is preserved on device.

  8. Override, Brightness 0, Color Green → Brightness 1 Initial state:

    • Visual: LED off
    • LED_Override: ON
    • LED_Color: 0,0,0
    • LED_Brightness: 0
    • LED_Switch: OFF
    "led_override": "off",
"led_override_color": "#00ff00",
"led_override_color_brightness": "0",

    Action:

    openhab:send LED_Brightness 1

    Result:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 120.000,100,1
    • LED_Brightness: 1
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#00ff00",
"led_override_color_brightness": "1",

  9. Override, Brightness 0, Color Green → ON Initial state:

    • Visual: LED off
    • LED_Override: ON
    • LED_Color: 0,0,0
    • LED_Brightness: 0
    • LED_Switch: OFF
    "led_override": "off",
"led_override_color": "#00ff00",
"led_override_color_brightness": "0",

    Action:

    openhab:send LED_Switch ON

    Result:

    • Visual: LED on
    • LED_Override: ON
    • LED_Color: 120.000,100,100
    • LED_Brightness: 100
    • LED_Switch: ON
    "led_override": "on",
"led_override_color": "#00ff00",
"led_override_color_brightness": "100",

jlaur avatar Oct 09 '24 21:10 jlaur