openhab-addons icon indicating copy to clipboard operation
openhab-addons copied to clipboard

Published 20 hours ago • verified publisher icon openhab

[denonmarantz] Wrong brand is set in vendor property

Open jlaur opened this issue 9 months ago • 3 comments

I just purchased a Denon AVC-X4800H to replace my beloved old Denon AVR-3808, and I noticed the wrong brand being set in the vendor property:

image

Serial number is the same as the MAC address, which starts with 00:06:78.

My old 3808 recievers's MAC address starts with 00:05:CD.

Expected Behavior

If vendor can be determined reliably, it should be set. Otherwise the property should not be set.

Current Behavior

The vendor is set based on false assumptions about MAC addresses:

https://github.com/openhab/openhab-addons/blob/321fde5486e3a282373a9183056b0e82a06218f5/bundles/org.openhab.binding.denonmarantz/src/main/java/org/openhab/binding/denonmarantz/internal/discovery/DenonMarantzDiscoveryParticipant.java#L47-L64

and set here:

https://github.com/openhab/openhab-addons/blob/321fde5486e3a282373a9183056b0e82a06218f5/bundles/org.openhab.binding.denonmarantz/src/main/java/org/openhab/binding/denonmarantz/internal/discovery/DenonMarantzDiscoveryParticipant.java#L87-L95

The assumption might have been correct in the past, but it seems that Sound United is now sharing more technology between the two brands, so it can no longer be assumed.

Possible Solution

Determining vendor should not be based on MAC address. It seems there is enough mDNS information to determine it:

image

I need to get my old 3808 online, and will check the mDNS result for this one as well.

Your Environment

  • Version used: 4.2 snapshot

jlaur avatar Apr 27 '24 10:04 jlaur

Additionally, the label is created like this: "Denon AVC-X4800H (Marantz Denon AVC-X4800H)"

jlaur avatar Apr 27 '24 13:04 jlaur

It seems old my Denon AVR-3808 can not be found through mDNS at all, only UPnP (screenshot from Device Spy):

image

As text:

  • Base URL http://192.168.0.44:8080/
  • Device icon Present, 48x48
  • Device URN urn:schemas-upnp-org:device:MediaRenderer:1
  • Embedded devices 0
  • Expiration timeout 1800
  • Friendly name Network Audio
  • Has presentation True
  • Interface to host 192.168.0.3
  • Manufacturer DENON
  • Manufacturer URL http://www.denon.com
  • Model description AV SURROUND RECEIVER
  • Model name AVR-3808
  • Model number 3808
  • Model URL http://www.denon.com/
  • Presentation URL http://192.168.0.44:8080/index.html
  • Remote endpoint 192.168.0.44:8080
  • Serial number 0005CDxxx
  • Services 4
  • Standard type MediaRenderer
  • Version 1.0

jlaur avatar Apr 27 '24 14:04 jlaur

Related: #16035

jlaur avatar Apr 27 '24 14:04 jlaur