openhab-addons
openhab-addons copied to clipboard
[emotiva] Initial contribution
This PR adds support for Emotiva Audio Corporation AV processors based on the Emotiva Network Remote Control protocol. Discovery is supported.
Binding has only been tested with an XMC-2, so please test and give feedback for other devices.
Has support for all Emotiva notification types in version 2.0 and 3.0 of the protocol, and adds support for almost all commands, has support for Zone 2 controls, browsing and controlling the menu and using the radio tuner.
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/emotiva-av-processor-binding/154406/1
The build is failing because your commit it not signed. See here for instructions to fix it: https://github.com/openhab/openhab-addons/pull/16499/checks?check_run_id=22412921872
While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: https://github.com/openhab/openhab-addons/pull/16499#discussion_r1613481822
After these are fixed i need one last review round.
While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment)
After these are fixed i need one last review round.
Pushed new changes that fixes all the SAT issues.
While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment) After these are fixed i need one last review round.
Pushed new changes that fixes all the SAT issues.
Thanks, Another step forward. There are 35 compile warnings, can you also look into those.
While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment) After these are fixed i need one last review round.
Pushed new changes that fixes all the SAT issues.
Thanks, Another step forward. There are 35 compile warnings, can you also look into those.
Now those have also been fixed.
Communication is established with Emotiva, just waiting on word from the people at Engineering.
Thanks for fixing the warnings and SAT errors. Looks very clean now. These are my final comments.
Fixed it all, added a few more translations and cleanup some descriptions.
Now, you could add your binding's logo to the openHAB website. ` See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website
Please also see the updated documentation here - SVG is now preferred: https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui
Now, you could add your binding's logo to the openHAB website. ` See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website
Please also see the updated documentation here - SVG is now preferred: https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui
Thanks for the good work in reviewing it. I always like this attention to detail.
Opened https://github.com/openhab/openhab-docs/pull/2310 for the logo in SVG format.