openhab-addons
openhab-addons copied to clipboard
openhab
[tapocontrol] new communication protocol integration / code revision
Tapocontrol-Binding for Tapo-Devices
this pr is necesarry because manufacturer changed communication protocol for some devices so device-communication is broken. because the communication changed i decided to revise the whole code of the plugin.
this pr has more changes:
- complete code revision
- integration new "klap-protocol"
- integration local device discovery with udp
- integration "H100 Smart-Hub"
- integration "T110 door-/window-contact sensor"
- integration "T310/T315 wheateher- sensors"
- supporting light-effects for light-strips
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/tapocontrol-control-tapo-smart-wifi-devices-with-openhab-official-support-thread/118389/338
@wildcs can you fix the conflict?
@lsiepel Can youn tell me how? The code has changed completeley. The old file has to be overwritten by the new one file. I dont have write access to do this
Can someone else help to resolve the conflict? @clinique @lolodomo maybe?
You need to rebase your PR and force push, it should do it.
Hello everybody. Please take a look on this request. Many people waiting for this to be merged. ;-) Thanks by advance!
Hello everybody. Please take a look on this request. Many people waiting for this to be merged. ;-) Thanks by advance!
does anyone know who/how to prompt openhab/add-ons-maintainers all the documentation re maintainers sees to be removed in 4.1.0 and the 4.0.1 links return 404 for me.? @clinique - gael i assume you are a maintainer- but can you merge after having done the review, its not clear anymore to a lowly user.
Hello everybody. Please take a look on this request. Many people waiting for this to be merged. ;-) Thanks by advance!
does anyone know who/how to prompt openhab/add-ons-maintainers all the documentation re maintainers sees to be removed in 4.1.0 and the 4.0.1 links return 404 for me.? @clinique - gael i assume you are a maintainer- but can you merge after having done the review, its not clear anymore to a lowly user.
I'm not a maintainer, only doing some code reviews from time to time. I know it works and will try to ping some maintainers so they can have a look ahead of the 4.1 final release. @lolodomo , @J-N-K , @jlaur if someone of you can have a look at it ?
Hello everybody. Please take a look on this request. Many people waiting for this to be merged. ;-) Thanks by advance!
does anyone know who/how to prompt openhab/add-ons-maintainers all the documentation re maintainers sees to be removed in 4.1.0 and the 4.0.1 links return 404 for me.? @clinique - gael i assume you are a maintainer- but can you merge after having done the review, its not clear anymore to a lowly user.
I'm not a maintainer, only doing some code reviews from time to time. I know it works and will try to ping some maintainers so they can have a look ahead of the 4.1 final release. @lolodomo , @J-N-K , @jlaur if someone of you can have a look at it ?
thankyou @clinique like i said, its difficult to understand current mmebers and process. <M>
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/openhab-4-1-milestone-discussion/149502/212
@holgerfriedrich Thanks for your review. Is solved your change requests. mvn javadoc:javadoc has now only warnings. mvn clean install is working fine for me. I don't know why Jenkins fails here now.
Please try to rebase. We have updated base libraries, thus the build is failing.
Hey Guys, had to do rebase and resolve confilcts manually because of core changes again. This PR contains a lot of changes to the origin but it was necesarry because of a protocol change by the device-vendor. So the old binding isnt working anymore for the most devices. I'm happy to continue to develop the binding, but it's always more work to keep this pr up to date on core changes.
@lolodomo @jlaur @openhab/add-ons-maintainers 2 reviewers already approved this changes. so please take a look soon. I know you have a lot of work and many PR to review and it hink you do this in your free time too. Thanks therefore.
Hello all. I hope this fix is merged very soon. I'm waiting for so long to get my items work again in my openhab installation. @lolodomo @jlaur please look at these MR!!! Thanks by advance!
@dor-bw until this PR is merged you can manually install my compiled .jar from my oh-compiled-addons repo.
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/manually-install-addons-on-ubuntu/153095/11
@dor-bw until this PR is merged you can manually install my compiled .jar from my oh-compiled-addons repo.
@wildcs Hello. This don't work for me. I followed your instructions from your github site but no Binding are shown in my openhab installation.
UPDATE: Now it works for me. The problem was between keyboard and chair.... Thanks for your work @wildcs. Hopefully this PR will be merged very soon.
@lsiepel Thanks for reviewing. Fixed your review requests except one minor. Yes this pr is tested well since the pr was created by many users and as you can see in some comments it's eagerly awaited Forgot to link the support-thread in the startpost. Most problems are because of some people didn't know how to install a binding manually the right way. The thing is: Without this pr, the binding isn't working for most devices anymore! So even if there should be some bugs it would be still better than it is now.
@lsiepel Thanks for reviewing. Fixed your review requests except one minor. Yes this pr is tested well since the pr was created by many users and as you can see in some comments it's eagerly awaited Forgot to link the support-thread in the startpost. Most problems are because of some people didn't know how to install a binding manually the right way. The thing is: Without this pr, the binding isn't working for most devices anymore! So even if there should be some bugs it would be still better than it is now.
I second this.
@lsiepel, I have been using the updated binding from the support thread since the 4th of December without problems to command my devices with the latest firmware (using the new KLAP protocol). This PR also fixes a problem I reported on a separate issue, as you can see from the comments. If necessary, we could ask on the support ticket all of the users with a GitHub account who have successfully used the updated binding to post a comment here.
@nelsonaponte Sorry Nelson, but if it is that urgent, contributers/developers should publish test versions of bindings through our marketplace. This is one of the reasons it was created for. It does not make sense if all users comment here.
Hi, @hmerk. That goes both ways. If the marketplace is so important for that, I hope it's specified somewhere (easy to find) so developers know about it. I'm not one but I couldn't find any mention of the "Marketplace" in the Documentation (Developer Guide and Developer Appendix) or even the Add-On Marketplace itself.
@nelsonaponte Sorry Nelson, but if it is that urgent, contributers/developers should publish test versions of bindings through our marketplace. This is one of the reasons it was created for. It does not make sense if all users comment here.
This wasn't clear for me too. I published it in the support-thread of the binding on oh-community
So you all have missed this announcement and many published bindings on the marketplace 😉
https://community.openhab.org/t/about-the-add-on-marketplace-category/123408
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/tapocontrol-control-tapo-smart-wifi-devices-with-openhab-official-support-thread/118389/408
@lsiepel Thanks for your review. Did a rebase and fixed your request. Hope it now can be merged soon.