openhab-addons icon indicating copy to clipboard operation
openhab-addons copied to clipboard

Published 20 hours ago • verified publisher icon openhab

[velbus] New functionality and bug fix

Open Rosen01 opened this issue 1 year ago • 5 comments

New functionality :

  • Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (fixes #14179)
  • Add module VMBDALI. (fixes #14654)
  • Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20

Fix bug :

  • No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (fixes #12702)
  • Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2.
  • Wrong typeId for bridge alarms management.
  • Trigger all the channels present in a packet. (bug reported here)

Signed-off-by: Daniel Rosengarten [email protected]

Rosen01 avatar Sep 27 '23 21:09 Rosen01

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/velbus-vmbpirm-only-ch3-supported/147834/4

openhab-bot avatar Sep 28 '23 05:09 openhab-bot

One thing to keep in mind as you peruse my review comments: I haven’t contributed to OpenHAB code in the past (so e.g. my knowledge of conventions in this project is non-existent), and the last time I have written any Java was also many, many years ago (so my knowledge of conventions in this entire ecosystem are also non-existent.)

If the comments don’t make sense or they suggest to do something the wrong way around, feel free to simply resolve that comment and forget ever seeing it :)

nagisa avatar Sep 30 '23 18:09 nagisa

This looks really nice so far. Unfortunately I haven’t the capabilities to help with driving the PR further. Hopefully my reviews have been helpful and whenever somebody with merge button powers comes along, they’ll be happy enough with the changes to be able to press it without further questions :)

nagisa avatar Oct 05 '23 15:10 nagisa

@cedricboon is there any chance you find time to check the code and accept the pull request ?

Rosen01 avatar Jan 30 '24 15:01 Rosen01

It seems that @cedricboon has no time to do the review. It would be nice if a maintainer (@lsiepel, @jlaur, @lolodomo, @fwolter) can review and, if it's OK, merge this pull request.

Rosen01 avatar Mar 08 '24 13:03 Rosen01