openhab-addons
openhab-addons copied to clipboard
openhab
[metOfficeDataHub] Initial contribution
[metOfficeDataHub] Initial code commit.
Addition of new Met Office Data Hub binding
-[metOfficeDataHub] Addition of new binding
Description
This is a new binding, which I have been using at home for more accurate temperature forecasts within the UK (I believe it does provide global data from the API definitions). Since moving to OH4 from OH3, I decided it had proven itself, over the last 10 months, so started doing the final pieces to raise this PR, so others can benefit from it as well.
The binding polls with careful consideration to the limitations of the met office API for free users (limited poll's per day), to retrieve forecast data, for each hour up to 24 hours, and for several days using daily forecasts. (For the duration of the systems runtime).
Testing
The core code base I have run at home for 10 months I think. Testing for this PR, has been checking the documented other channels that I do not use, and adjust as necessary comparing the raw values from the API in postman to those polled for the London example given.
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/uk-met-office-weather-service-binding/148346/1
@lsiepel Thank you for all the time looking through - I am looking through the feedback this weekend and will start applying the suggestions. I also need to do some minor updates to support a new revision of the API's so will also be adding those while updating based on the comments.
No need to force push, regular commits are better so I can track changes. Will try to look into this binding next weekend
Thank you (I guess I don't need to click the request re-review then :) ) - sorry I was pushing a lot of small one's before - previously people have requested they are squashed - so I was doing so to minimise the history. (Also I did one mistake so had to there in order to undo date corrections across several other repo's that must have had the wrong copyright markers when I did a search and replace on the wrong scope).
I think all the changes are done now - I just need to back compile it for my home systems, and any others currently using the current build, due to some API updates for v4.1
Thanks again for all your time reviewing it! :)
On Sun, 3 Mar 2024 at 21:29, lsiepel @.***> wrote:
No need to force push, regular commits are better so I can track changes. Will try to look into this binding next weekend
— Reply to this email directly, view it on GitHub https://github.com/openhab/openhab-addons/pull/15367#issuecomment-1975331653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBCTQY4IKONAG6TYSIISQLYWOI2VAVCNFSM6AAAAAA3DKOA3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGMZTCNRVGM . You are receiving this because you authored the thread.Message ID: @.***>