openhab-addons icon indicating copy to clipboard operation
openhab-addons copied to clipboard

[Velbus] Unloading the bridge fails predictably

Open nagisa opened this issue 1 year ago • 4 comments

NB: this is not a request for somebody to fix the issue, I anticipate getting around to looking at it myself in near future.

To reproduce this issue, I have a things file that contains a single velbus bridge with a single device in it:

Bridge velbus:bridge:1 "Velbus" [ port="/dev/ttyACM0", timeUpdateInterval="1500" ] {
    vmbpirm   01 [ address = "01" ]
}

Every time this file is modified and saved, openhab will attempt to unload and reload the thing.

Expected Behavior

The thing is successfully reloaded, and the system works without significant interruptions.

Current Behavior

karaf[2811996]: [WARN ] [core.thing.internal.ThingManagerImpl] - Disposing handler for thing 'velbus:bridge:1' takes more than 5000ms.
karaf[2811996]: [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model 'velbus.things'
karaf[2810306]: [WARN ] [.core.thing.binding.BaseThingHandler] - Handler VelbusSerialBridgeHandler tried updating the thing status although the handler was already disposed.
{last message repeated a fair number of times}

Possible Solution

Need to investigate why disposing of the velbus thing does not work correctly.

Steps to Reproduce (for Bugs)

  1. Set up openhab with a velbus thing via a configuration file as specified above;
  2. Modify the configuration file and save it.

Context

Restarting every time I modify the configuration file is a major pain :)

Your Environment

  • Version used: openHAB 3.4.2; Velbus binding 3.4.2
  • Environment name and version: N/A
  • Operating System and version: NixOS running on nVidia Jetson AGX, linux kernel 5.10, aarch64

nagisa avatar May 04 '23 21:05 nagisa