openhab-addons
openhab-addons copied to clipboard
openhab
[ClementineRemote] Initial contribution
ClementineRemote Binding
This new binding allows controlling Clementine Player from OpenHAB.
The binding is located @ bundles/org.openhab.binding.clementineremote.
Description
Connection between Handler and Clementine Player is done via Google Protocol Buffers.
The protobuf definition file is included in the folder proto.
Based on this definition file, a class ClementineRemote.java has been generated in the package bundles/org.openhab.binding.clementineremote/src/main/java/de/qspool/clementineremote/backend/pb via the command
bundles/org.openhab.binding.clementineremote$> protoc --java_out=src/main/java/ proto/remotecontrolmessages.proto
OpenHAB version
As per request from Maintainer, this commit is now based on lastest 4.0.0 main.
Static Code Analysis
All code in org/openhab/binding/clementineremote should conform to the requirements given in the Coding Guidelines.
However the code in de/qspool/clementineremote/backend/pb does not! As this class is script-generated, I think it should be excluded from code analysis.
There already is a thread for discussion of that topic.
I fixed all suggestions by lsiepel – with on exception:
I did not change the channel type of playback-control to the predefined system.media-control, as that does not seem to support STOP command.
I fixed all suggestions by lsiepel – with on exception:
I did not change the channel type of playback-control to the predefined system.media-control, as that does not seem to support STOP command.
Great, some small issues left. Maybe look at some other binding regarding the player / media control. Don't have a real opinion on it, juist know there is a dedicated control for such tasks.
I leave this now for a real maintainer to review. :-)
Hm, any progress here? Did I miss something when fixing the denoted issues?
@StephanRichter there has been some time without any updated / commits to this PR. Do you think you will be able to finish this or did you abandon this PR? At some time we will close this PR due to inactivity.