openhab-addons icon indicating copy to clipboard operation
openhab-addons copied to clipboard

Published 20 hours ago • verified publisher icon openhab

[modbus] [WIP] Add support for Sungrow Hybrid Inverters

Open ferdisdot opened this issue 3 years ago • 4 comments

This PR adds support for Sungrow Hybrid Inverters connected via Modbus TCP. I tested the binding with a Sungrow SH10RT device, but, acccording to the register definition it should work for all devices of SHRT series and for devices of SHRS and SHK series.

As this is my first contribution to openHAB I'm happy on any feedback.

ferdisdot avatar Aug 14 '21 21:08 ferdisdot

@ferdisdot Did you address @ssalonen comments?

fwolter avatar Jan 01 '22 18:01 fwolter

Hi @fwolter, I started to work on it, but last month were quite busy. So the last few month I couldn't work on it. I hope I may get back to this until end of January. If you would like to contribute in the meantime feel free to do so. As this is my first work in java I'm not sure about the type questions that @ssalonen raised (int vs. Integer). I would appreciate any help here.

ferdisdot avatar Jan 02 '22 20:01 ferdisdot

If you use Integer instead of int you're consuming a bit more resources and Integer can also be null, which needs to be handled correctly. So, using int makes things simpler and consumes less resources.

You made some changes to the code. Please raise your hand if you're read for another review round.

fwolter avatar Feb 20 '22 18:02 fwolter

@ferdisdot what is the current state of this PR? Are there still things to address before another (hopefully last) review round can take place?

lsiepel avatar Jan 24 '23 22:01 lsiepel

Unfortunately it looks like we cannot bring this PR to the finish line. After two years of inactivity i close this PR. If there is a need to restart, feel free to re-open or start a new PR.

lsiepel avatar Jun 15 '24 17:06 lsiepel