hippo4j icon indicating copy to clipboard operation
hippo4j copied to clipboard

refactor 1171: optimize @Deprecated coreSize and maxSize

Open jjiey opened this issue 1 year ago • 4 comments

Fixes #1171

Changes proposed in this pull request:

Check mailbox configuration when submitting. Contributor Guide

  • Fix all ThreadPoolParameterInfo.java @Deprecated related calls
  • Modify property names and related calls
    • ThreadPoolBaseInfo.java / ThreadPoolAdapterState.java / GlobalRemotePoolInfo.java: coreSize => corePoolSize
    • ThreadPoolBaseInfo.java / ThreadPoolAdapterState.java: maximumSize => maximumPoolSize
    • GlobalRemotePoolInfo.java: maxSize => maximumPoolSize

jjiey avatar May 04 '23 09:05 jjiey

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (9a1089f) 28.46% compared to head (e24c0e9) 28.46%.

:exclamation: Current head e24c0e9 differs from pull request most recent head a066e01. Consider uploading reports for the commit a066e01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1219   +/-   ##
==========================================
  Coverage      28.46%   28.46%           
  Complexity       730      730           
==========================================
  Files            257      257           
  Lines           5887     5887           
  Branches         551      551           
==========================================
  Hits            1676     1676           
  Misses          4059     4059           
  Partials         152      152           
Impacted Files Coverage Δ
.../cn/hippo4j/common/model/GlobalRemotePoolInfo.java 0.00% <ø> (ø)
...core/executor/state/AbstractThreadPoolRuntime.java 0.00% <0.00%> (ø)
...in/java/cn/hippo4j/common/toolkit/ContentUtil.java 96.66% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 04 '23 09:05 codecov[bot]

The modification scope of this PR is too large, especially the change of cn.hippo4j.common.model.ThreadPoolParameterInfo, which will cause Hippo4j to fail to upgrade.

magestacks avatar May 04 '23 13:05 magestacks

It is recommended to sort out the range of changes under different models, and make modifications after evaluation.

magestacks avatar May 04 '23 13:05 magestacks

Hi. Is it convenient to split the changes to re-examine the code? We need to think more about compatibility and stability. tks!

iwangjie avatar Jul 03 '23 01:07 iwangjie