Jason Coward

Results 160 comments of Jason Coward

@smg6511 — I am trying to get a collaborative review session together for this PR so we can get it integrated sooner than later. If possible, could you resolve the...

> @opengeek - I fixed the conflict but, dagonit, unintentionally ended up merging not force pushing because I was trying to fix a minor format error at the same time...

I think you should be able to go back to [8c6a110](https://github.com/modxcms/revolution/pull/16653/commits/8c6a110b15f3b0d23aa7bd6063c9c184bfc3bbf1) and then rebase the the work on the latest 3.x. I'm not sure exactly the situation, but maybe you...

> @theboxer - Quick question: I've not pulled down a fork of a fork before; what's the best way of going about that? To this point I've used Github Desktop...

> Ok, so basically fork John's revo repo is what you're suggesting, right? No, you just add his fork as a remote to your local git repo.

If we have depended on the JS showing these in the proper timezone in the browser without needing server_offset_time to be managed before now, then this could be a problem.

This implementation still seems overly complicated to me. I don't understand the need for all these settings and a formatting class. PHP provides date formatting that should be sufficient to...

Further, we need to make sure the permissions being updated are from the appropriate templates. You would need to limit the query by template ids for the targeted template group(...

> @opengeek > > > You would need to limit the query by template ids for the targeted template group( s ). > > Why do we need a template...

@smg6511 I see changes to the CSS related to the display-switch class, and I'm wondering if this is where the inconsistency was introduced after 3.0.1. Can you take a look...